fix: default the resolved customer
to the current user
#787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
This PR fixes the
RootQuery.customer
query to default to the current user. This prevents mismatches where the user is logged in, but thecustomer
is still a guest session.The underlying issue is that the customer resolver was previously only using the existing woocommerce-session (if it exists) or an explicit id passed by as an arg, but never the current authenticated user's ID. This could lead to a situation (first-time queries usually) where a user is authenticated with an Authorization header, but the customer is a guest session.
After the change, the resolver defaults to using the current user id, and will only fallback to the guest session if no user is logged in.
Does this close any currently open issues?
Not that I know of.
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
Didn't add a unit test for this since I cant get the test env running, but it should essentially:
wp_set_current_user( $some_user )
;customer.id !== 'guest'
andcustomer.databaseId
===viewer.databaseId
=== the logged in user.Where has this been tested?
dev-develop