Add associated args --new and --old #150

marksabbath · 2020-11-22T19:53:19Z

This PR introduces 2 new associated arguments to the search-replace command in an effort to resolve the bug reported on #132

With this approach, if users need to replace strings starting with more than one dash (i.e --mystring) they will be able to do that by using the new associated arguments: wp search-replace --old='--oldstring' --new='newstring'.

Update scaffolded README and GitHub configuration

…ash.

Restrict some search-replace tests to wp_posts to avoid wp_options cl…

…mand into wp-cli#31

Add `--skip-tables=<tables>` argument to exclude tables when performing search-replace

Remove unnecessary `array_diff()`; skipping within loop is clearer

…singular verbs.

Convert search-replace subcommand help summaries to use third-person singular verbs.

Fix GitHub label generation

…d-only.

Adapt feature test to use HTTPS with example.com

schlessera · 2022-01-05T23:46:45Z

We need to check whether both $old and $new were provided by the user, in any combination.

As you've probably noticed, we cannot check this based on the value of the arguments, as an empty string is a valid value (at least for $new), so we have to check based on the presence of the arguments/flags instead.

Also, we'll need functional tests to ensure the flags work as expected.

marksabbath · 2022-01-06T17:34:49Z

We need to check whether both $old and $new were provided by the user, in any combination.

As you've probably noticed, we cannot check this based on the value of the arguments, as an empty string is a valid value (at least for $new), so we have to check based on the presence of the arguments/flags instead.
Great point @schlessera I'll work on that.

Also, we'll need functional tests to ensure the flags work as expected.
Yeah, I rebased with that purpose. I'll work on that on my next round :)

marksabbath · 2022-07-25T14:14:47Z

Hey @schlessera would you mind taking another look at this PR?

danielbachhuber · 2022-07-28T15:12:58Z

.github/workflows/regenerate-readme.yml

@@ -95,7 +96,7 @@ jobs:
        uses: repo-sync/pull-request@v2
        with:
          source_branch: regenerate-readme
-          destination_branch: master
+          destination_branch: ${{ github.event.repository.default_branch }}
          github_token: ${{ secrets.GITHUB_TOKEN }}
          pr_title: Regenerate README file
          pr_body: "**This is an automated pull-request**\n\nRefreshes the `README.md` file with the latest changes to the docblocks in the source code."


Is it possible to update your branch so the changes to .github/* don't appear in the diff?

You mean rebase it? I did that before pushing, but will do that again.

danielbachhuber · 2022-07-28T15:16:46Z

src/Search_Replace_Command.php

@@ -47,10 +47,16 @@ class Search_Replace_Command extends WP_CLI_Command {
 	 *
 	 * ## OPTIONS
 	 *
-	 * <old>
+	 * [<old>]


I don't love that we're changing the behavior of the positional arguments to fix this very small edge case.

Might it be possible to handle this in wp-cli/wp-cli somehow? Better handling of positional arguments that look like associative arguments?

Alternatively, is there some other workaround that could be employed for this edge case?

It's been quite a long time since I did the tests, but I do remember that I couldn't find a way to make that work properly without using this approach.

Maybe a change under wp-cli/wp-cli making it aware of which are the accepted associative args and use it as positional if it does not recognize it?

danielbachhuber · 2022-11-18T17:04:41Z

Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/6c398217cff94e8a23a94b6b23aca3aa in case this PR is auto-closed or broken in some way.

gitlost and others added 30 commits November 21, 2017 00:39

Merge pull request wp-cli#47 from wp-cli/scaffold-readme-github-11-20

caa107e

Update scaffolded README and GitHub configuration

--skip-tables implemented.

8a68f30

Updated method of removing tables.

21c8abb

Functional tests added.

e89a89c

Regenerate README for new option

a5237e8

Fix step definition

e10f4c9

Removed extra spaces from Functional tests.

7b3a453

New attempt to remove extra spaces for Functional tests.

5d76068

Added space at the end of VALUES.

9521b5a

Restrict some search-replace tests to wp_posts to avoid wp_options cl…

609d95c

…ash.

Merge pull request wp-cli#49 from wp-cli/allow_for_options

8dd8cd2

Restrict some search-replace tests to wp_posts to avoid wp_options cl…

--skip-tables implemented.

1d7fd9b

Updated method of removing tables.

88b0b02

Functional tests added.

6f2557b

Regenerate README for new option

d41ee74

Fix step definition

459803d

Removed extra spaces from Functional tests.

908c2a2

New attempt to remove extra spaces for Functional tests.

22a54bf

Added space at the end of VALUES.

071c175

Merge branch 'wp-cli#31' of github.com:marksabbath/search-replace-com…

282570e

…mand into wp-cli#31

Merge pull request wp-cli#48 from marksabbath/wp-cli#31

25a580a

Add `--skip-tables=<tables>` argument to exclude tables when performing search-replace

Remove unnecessary array_diff(); skipping within loop is clearer

e5a7fc8

Merge pull request wp-cli#50 from wp-cli/48-remove-array-diff

d358907

Remove unnecessary `array_diff()`; skipping within loop is clearer

Convert search-replace subcommand help summaries to use third-person …

c08dc31

…singular verbs.

Merge branch 'master' into issue/doc-verbs

f45d5ad

Regenerate README from command docs

7f7cca8

Merge pull request wp-cli#51 from DrewAPicture/issue/doc-verbs

6a85863

Convert search-replace subcommand help summaries to use third-person singular verbs.

Fix GitHub label generation

1b59bbb

Merge pull request wp-cli#52 from wp-cli/fix-github-labels

5db59b4

Fix GitHub label generation

Do not show on report tables without index when using --report-change…

83a3150

…d-only.

schlessera and others added 11 commits December 2, 2021 15:40

Update file(s) from wp-cli/.github

230adf3

Update file(s) from wp-cli/.github

342593e

Add php 8.1 support

f23f767

Merge pull request wp-cli#166 from wojsmol/fix/phpp8.1-compat

100e01c

Update file(s) from wp-cli/.github

79bfd00

Adapt feature test to use HTTPS with example.com

091c8d3

Merge pull request wp-cli#167 from wp-cli/fix/use-https-example-com

dbf2156

Adapt feature test to use HTTPS with example.com

Add assoc args --new and --old

39ac112

Removes the empty statement

0e0cbbe

Add assoc args --new and --old

f180f48

Removes the empty statement

a89614e

schlessera force-pushed the master branch from 7c20dee to a89614e Compare January 5, 2022 23:42

schlessera and others added 11 commits January 6, 2022 22:05

Update file(s) from wp-cli/.github

a0531d3

Update file(s) from wp-cli/.github

480cd86

Update file(s) from wp-cli/.github

eeb96b1

Update file(s) from wp-cli/.github

d9d9825

Update file(s) from wp-cli/.github

461cc65

Add assoc args --new and --old

c3f8c36

Removes the empty statement

911d78a

Add assoc args --new and --old

8e3b3ed

Removes the empty statement

d2eab35

Merge branch 'master' of github.com:marksabbath/search-replace-command

b670b67

Check if both args --old and --new are present and add behat tests

6ea31b7

danielbachhuber reviewed Jul 28, 2022

View reviewed changes

danielbachhuber closed this Nov 18, 2022

danielbachhuber force-pushed the master branch from 288c656 to fa755eb Compare November 18, 2022 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add associated args --new and --old #150

Add associated args --new and --old #150

marksabbath commented Nov 22, 2020

schlessera commented Jan 5, 2022

marksabbath commented Jan 6, 2022

marksabbath commented Jul 25, 2022

danielbachhuber Jul 28, 2022

marksabbath Aug 11, 2022

danielbachhuber Jul 28, 2022

marksabbath Aug 11, 2022

danielbachhuber commented Nov 18, 2022

Add associated args --new and --old #150

Add associated args --new and --old #150

Conversation

marksabbath commented Nov 22, 2020

schlessera commented Jan 5, 2022

marksabbath commented Jan 6, 2022

marksabbath commented Jul 25, 2022

danielbachhuber Jul 28, 2022

Choose a reason for hiding this comment

marksabbath Aug 11, 2022

Choose a reason for hiding this comment

danielbachhuber Jul 28, 2022

Choose a reason for hiding this comment

marksabbath Aug 11, 2022

Choose a reason for hiding this comment

danielbachhuber commented Nov 18, 2022