A light edit to "Pull Requests" to begin to address some detail gaps #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitlost
approved these changes
Jun 21, 2017
| @@ -20,11 +24,15 @@ Lastly, please follow the [WordPress Coding Standards](http://make.wordpress.org | |||
|
|
|||
| If you haven't submitted a pull request before, you'll want to install WP-CLI for local development: | |||
|
|
|||
| 1. Clone this git repository on your local machine. | |||
| 1. Clone the WP-CLI git repository to your local machine: `git clone [email protected]:wp-cli/wp-cli.git ~/wp-cli` | |||
There was a problem hiding this comment.
Would it be better here to use the "https://github.com" version of the request? It works for everyone, whereas for instance for me git clone git@... doesn't.
| 4. Run `./bin/wp --info` to test if everything was installed properly. | ||
|
|
||
| Commands bundled with WP-CLI (e.g. `wp scaffold plugin`) will be editable from the `vendor/wp-cli` directory (e.g. `vendor/wp-cli/scaffold-command`). You'll need to fork the repository appropriately in order to have an `origin` to push to. | ||
|
|
||
| Commands available for standalone installation (e.g. `wp dist-archive`) can be installed from source (e.g. `wp package install [email protected]:wp-cli/dist-archive-command.git`). Run `wp package path <package-name>` to find the appropriate directory to edit. |
schlessera
pushed a commit
that referenced
this pull request
Jan 25, 2022
A light edit to "Pull Requests" to begin to address some detail gaps (Maybe consider the "https://github.com" request suggestion.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #57, #10, #17