Added a small text to understand that the links only work for WP-CLI organization team #505
Conversation
…organization team The links for the maintainers and committers will only load for those who are part of the WP-CLI organization. So, others outside the GH organization see a 404 error when checking it.
| @@ -4,6 +4,8 @@ Some people have write access to WP-CLI repositories. These people are identifie | |||
|
|
|||
| * [maintainers](https://github.com/orgs/wp-cli/teams/maintainers) - Project leadership | |||
| * [committers](https://github.com/orgs/wp-cli/teams/committers) - Trusted contributors | |||
|
|
|||
| The above links are not public; they only work for GitHub users who are part of the WP-CLI GitHub organization. | |||
There was a problem hiding this comment.
@schlessera @danielbachhuber @swissspidy I'm uncertain about whether these teams should be visible to the public. If they should be, we'll need to adjust their visibility settings, as outlined here: https://docs.github.com/en/organizations/organizing-members-into-teams/changing-team-visibility.
There was a problem hiding this comment.
They are already visible. The problem is even visible teams are only visible to organization members, not the general public. Teams cannot be made publicly visible. That's also what that documentation says.
Given that this page is for committers and committers are part of the GitHub org anyway, I don't really see an issue with that though.
There was a problem hiding this comment.
Oh, huh. I always thought they were publicly accessible. That was the original intent — to provide visibility into who makes decisions.
There was a problem hiding this comment.
Committers and maintainers links are used in several other pages also, like governance, code review, etc. It would be nice thing to be able to view who are maintaining the project by non-team members also.
There was a problem hiding this comment.
"People" shows nine members without being logged in to GitHub, thirteen when I'm logged in.
The links for the maintainers and committers will only load for those who are part of the WP-CLI organization. So, others outside the GH organization see a 404 error when checking it.