Fix handbook generation when Phar is used directly #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
reviewed
Dec 8, 2023
| @@ -31,6 +32,7 @@ if ( 20 != substr( $md5_response->status_code, 0, 2 ) ) { | |||
| WP_CLI::error( "Couldn't access md5 hash for release (HTTP code {$response->status_code})" ); | |||
| } | |||
| ``` | |||
| or in the body for POST requests. | |||
There was a problem hiding this comment.
@schlessera Where is this coming from? 🤔 Looks a bit out of place
There was a problem hiding this comment.
Hmm, good catch. Looks like the parsing fails here.
There was a problem hiding this comment.
I have created a new issue for this: #477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where the handbook generation is triggered via anything else than the
wp-cli-devenvironment, the script was broken and did not correctly recognize the$repo_url.This change fixes this to make sure packages are correctly identified from within a
vendorfolder.