Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show additional plugin headers values in wp plugin get <plugin> output #414

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Show additional plugin headers values in wp plugin get <plugin> output #414

merged 6 commits into from
Apr 25, 2024

Conversation

ernilambar
Copy link
Member

  • Plugin header RequiresPlugins is also displayed if exists.
  • Added feature test for plugin get. One scenario for RequiresPlugins and one with basic test in separate file plugin-get.feature

Related: #407

@ernilambar ernilambar changed the title Expand plugin get output and add tests for the command Show RequiresPlugins in plugin get output Apr 11, 2024
@ernilambar ernilambar changed the title Show RequiresPlugins in plugin get output Show RequiresPlugins header value in plugin get output Apr 11, 2024
@ernilambar ernilambar changed the title Show RequiresPlugins header value in plugin get output Show RequiresPlugins header value in plugin get output Apr 11, 2024
@ernilambar ernilambar marked this pull request as ready for review April 15, 2024 05:43
@ernilambar ernilambar requested a review from a team as a code owner April 15, 2024 05:43
swissspidy
swissspidy reviewed Apr 15, 2024
View reviewed changes
src/Plugin_Command.php Outdated Show resolved Hide resolved
@swissspidy
Copy link
Member

Makes we wonder whether we shouldn't add more information from get_plugin_data to this list by default. For example the RequiresWP and RequiresPHP information could be useful (both added in 5.3), or UpdateURI (added in 5.8)

@ernilambar
Copy link
Member Author

@swissspidy We could keep name, title, author, version, description and status as default fields and other as optional AVAILABLE FIELDS. And for available optional fields we could add those new fields, like requires_plugins, requires_php, etc.

@ernilambar ernilambar changed the title Show RequiresPlugins header value in plugin get output Show additional plugin headers values in wp plugin get <plugin> output Apr 25, 2024
swissspidy
swissspidy reviewed Apr 25, 2024
View reviewed changes
src/Plugin_Command.php Outdated Show resolved Hide resolved
@swissspidy
Copy link
Member

Now that #417 is merged, merging main into this branch should fix the tests

@swissspidy swissspidy added this to the 2.1.20 milestone Apr 25, 2024
@swissspidy swissspidy merged commit e81579d into wp-cli:main Apr 25, 2024
38 checks passed
@ernilambar ernilambar deleted the update/plugin-get-deps branch April 26, 2024 07:17
@pedro-mendonca pedro-mendonca mentioned this pull request Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
command:plugin-get
Projects
None yet
Milestone
2.1.20
Development

Successfully merging this pull request may close these issues.
2 participants
@ernilambar @swissspidy