cache-flush check: Return early if a match is found #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently scan all the PHP files in the target WP content dir looking for `wp_cache_flush()` uses, however we are not currently using the results in a meaninful way so we can just probably return early if the current check found a match. If there are plans to list the matched files, we can probably attempt to use some more performan alternatives (grep if available for example) which should be likely faster than a PHP based implementation. See wp-cli#178
swissspidy
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently scan all the PHP files in the target WP content dir looking for
wp_cache_flush()uses, however we are not currently using the results in a meaninful way so we can just probably return early if the current check found a match.If there are plans to list the matched files, we can probably attempt to use some more performan alternatives (grep if available for example) which should be likely faster than a PHP based implementation.
See #178