Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Check for metadata #135

Closed
wants to merge 2 commits into from

Conversation

BhargavBhandari90
Copy link

@BhargavBhandari90 BhargavBhandari90 commented Dec 1, 2017

For #94

@BhargavBhandari90
Copy link
Author

BhargavBhandari90 commented Dec 1, 2017

@danielbachhuber
There are already two meta tags available on fresh WP setup which are

<meta name="viewport" content="width=device-width, initial-scale=1">
    <meta name="generator" content="WordPress 4.8.4" />

So I think we have to ignore these and find other than these two meta tags right?
Because if we check for any one meta tag availability , then it will always return true.

public function run() {

// Fetch homepage resposne.
$response = wp_remote_get(site_url());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than make a remote request, we should instead render and parse the template.

@danielbachhuber
Copy link
Member

So I think we have to ignore these and find other than these two meta tags right?
Because if we check for any one meta tag availability , then it will always return true.

Sorry, to clarify, the end user should be able to define which meta tags they expect to be present.

@danielbachhuber
Copy link
Member

@BhargavBhandari90 Planning to pick this back up?

@BhargavBhandari90
Copy link
Author

BhargavBhandari90 commented Dec 12, 2017

Yes, @danielbachhuber. I was little busy last weekend. I'll try to provide a solution within this week.

@danielbachhuber
Copy link
Member

Closing per lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants