Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Validate MIME type against extensions" #130

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Nov 14, 2017

Reverts #120

See #129
Previously #88

@schlessera
Copy link
Member

schlessera commented Nov 14, 2017

Shall we try switching to finfo_file() first before reverting everything?
See #129 (comment)

@davegaeddert
Copy link
Contributor

FWIW I did actually try finfo_file(). Still got some failing tests and kinda gave up on it, felt like I didn't know enough to get to the root of the problem:

https://github.com/flinthillsdesign/doctor-command/pull/7
https://travis-ci.org/flinthillsdesign/doctor-command/builds/301749936

@danielbachhuber
Copy link
Member Author

Shall we try switching to finfo_file() first before reverting everything?

No. It's unstable code blocking other work, so it should be reverted and fixed on a subsequent PR.

@schlessera schlessera added this to the 0.2.0 milestone Nov 14, 2017
@schlessera schlessera merged commit fa02aa0 into master Nov 14, 2017
@schlessera schlessera deleted the revert-120-feature/GH#88 branch November 14, 2017 20:39
schlessera added a commit that referenced this pull request Jan 6, 2022
Revert "Validate MIME type against extensions"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants