Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor config create command" #185

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

swissspidy
Copy link
Member

Reverts #181 as it seems to cause a lot of test failures in other commands. This should help unblock the v2.11 release.

See discussion at https://wordpress.slack.com/archives/C02RP4T41/p1722327383849819

We should investigate those failures so that we can re-introduce that PR with appropriate bug fixes, test coverage, and increased confidence.

@swissspidy swissspidy added this to the 2.3.6 milestone Aug 5, 2024
@swissspidy swissspidy requested a review from a team as a code owner August 5, 2024 12:31
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the PR look clear - they correctly reverted the PR that caused some tests to fail.

@swissspidy swissspidy merged commit 82a64ae into main Aug 5, 2024
34 checks passed
@swissspidy swissspidy deleted the revert-181-94-refactor-config-command branch August 5, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants