Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor config create command #181

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Refactor config create command #181

merged 3 commits into from
Jul 22, 2024

Conversation

UmeshSingla
Copy link
Contributor

@UmeshSingla UmeshSingla commented May 18, 2024 •
edited by swissspidy
Loading

Fixes: #94
Fixes #180

Refactored code for wp config create command renders the default moustache template with default values along with the extra-php input if specified. And further it uses update method from WPConfigTransformer class to set the config values for all provided arguments.

@UmeshSingla UmeshSingla requested a review from a team as a code owner May 18, 2024 13:09
@ernilambar
Copy link
Member

@UmeshSingla Can you please add tests also? Ref: Functional Tests

ernilambar
ernilambar reviewed May 20, 2024
View reviewed changes
src/Config_Command.php Outdated Show resolved Hide resolved
@UmeshSingla
Copy link
Contributor Author

UmeshSingla commented May 20, 2024 •
edited
Loading

@UmeshSingla Can you please add tests also? Ref: Functional Tests

@ernilambar Aren't the existing tests enough? If not, Could you possibly provide me with an example of changes that can use additional tests.

https://github.com/wp-cli/config-command/blob/main/features/config-create.feature

@ernilambar
Copy link
Member

@UmeshSingla Can you please add tests also? Ref: Functional Tests

@ernilambar Aren't the existing tests enough? If not, Could you possibly provide me with an example of changes that can use additional tests.

https://github.com/wp-cli/config-command/blob/main/features/config-create.feature

For refactoring part, current tests are fine. Adding test for this issue #180 would be good.

@UmeshSingla
Copy link
Contributor Author

@ernilambar I've added functional test for #180. Does this looks ok to you? 0601669

@UmeshSingla UmeshSingla mentioned this pull request Jun 13, 2024
Open
2 tasks
@swissspidy swissspidy added this to the 2.3.5 milestone Jul 22, 2024
@swissspidy swissspidy merged commit a4ae2c7 into wp-cli:main Jul 22, 2024
38 checks passed
This was referenced Aug 5, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernilambar ernilambar ernilambar approved these changes

Assignees
No one assigned
Labels
command:config-create
Projects
None yet
Milestone
2.3.5
3 participants
@UmeshSingla @ernilambar @swissspidy