Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Spell Checker #95

Closed
wants to merge 1 commit into from
Closed

Introduce Spell Checker #95

wants to merge 1 commit into from

Conversation

ernilambar
Copy link
Member

No description provided.

@ernilambar ernilambar requested a review from a team as a code owner January 11, 2024 15:47
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, @ernilambar !

Can you share a bit more context as to the problem solved by this workflow action? I'm hesitant about adding a bunch of supplemental actions, even if they seem like they might be useful.

@ernilambar
Copy link
Member Author

@danielbachhuber There was several typos in our CLI commands classes. So rather than fixing manually, it was an approach to try minimize those typos by using Action.
See discussion here - wp-cli/scaffold-package-command#225 (comment)

But unfortunately that Spell Checker also did not catch several typos which we were expecting to be caught. So I am also not 100% sure if this spell checker should be added. If we could find better Spell Checker it would be great.

@danielbachhuber
Copy link
Member

Ok, let's leave things as they are for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants