Fix domain validation function ✅

wotschofsky · Dec 15, 2024 · 78ee327 · 78ee327
1 parent a8184a4
commit 78ee327
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/utils.test.ts b/lib/utils.test.ts
@@ -113,6 +113,7 @@ describe('isValidDomain', () => {
         'theofficialabsolutelongestdomainnameregisteredontheworldwideweb.international',
       ),
     ).toBe(true);
+    expect(isValidDomain('_dmarc.example.com')).toBe(true);
   });
 
   it('validates wildcard domains', () => {

diff --git a/lib/utils.ts b/lib/utils.ts
@@ -37,7 +37,7 @@ export const isValidDomain = (domain: string) => {
   if (domain.length > 253 || domain.length === 0) return false;
 
   // Remove wildcard prefix or leading underscore, trailing dot (if fully qualified domain name)
-  const cleanedDomain = domain.replace(/^(\*\.)|_/, '').replace(/\.$/, '');
+  const cleanedDomain = domain.replace(/^(\*\.|_)/, '').replace(/\.$/, '');
 
   // Split domain into labels
   const labels = cleanedDomain.split('.');