Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for other SIPS2 APIs #9

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

Jydett
Copy link
Contributor

@Jydett Jydett commented Jan 20, 2022

Hi, this WIP PR adds support to others SIPS2 API (only Office -> wallet for now)

  • This include a refactor to extract the common parts
  • The module common-payment-sdk is renamed common-sdk
  • A new module wallet-sdk is created

TODO

  • Refactor code base
  • Payement tests workings with refactor
  • Implements wallets methods (getWalletData & deletePaymentMean)
  • TU
  • Javadoc

Feedback appreciated !

w112739 added 7 commits January 20, 2022 17:09
 - factorize common code in sdk-common
 - remove sdk-payment common

No javadoc yet
…o worldline_develop

� Conflicts:
�	payment-sdk/build.gradle
 - Seal computation now sort all fields of a class hierarchy instead of sorting on each class
 - Fix broken seal calculator tests
@CrlH
Copy link
Collaborator

CrlH commented Jan 21, 2022

Great work so far, @Jydett!

Couple remarks up until now

  • SIPS 1.0 is EOL and only ever sold in FR. I’d propose not to use any sips 2.0 references, as this will cause unneeded confusion

  • ING Home’Pay is discontinued by ING and will shortly be removed from SIPS

@Jydett
Copy link
Contributor Author

Jydett commented Jan 21, 2022

Ok @CrlH thx for the feedback.
I'll remove the SIPS 2.0 references and ING HomePay.

A couple a unit tests and documentations and this should be ready to review :D

On a side note are you interested to add github actions to this project ? (this could be done in another PR if you are interested)

Jydett and others added 5 commits January 22, 2022 17:37
 - fix javadoc
 - fix exception bad imports
 - remove unused code
 - add few tests
 - accept unknown response code
 - fix javadoc
 - fix exception bad imports
 - remove unused code
 - add few tests
 - accept unknown response code
@Jydett Jydett marked this pull request as ready for review January 24, 2022 15:00
@Jydett
Copy link
Contributor Author

Jydett commented Jan 24, 2022

This si worth noting that this could be a major version since some imports and names changed

@Jydett
Copy link
Contributor Author

Jydett commented Jan 24, 2022

I've updated the readme without changing the version number since I'm not sure how you want to bump the lib version with this PR

w112739 added 3 commits February 25, 2022 18:36
 - YearMonth is correctly parsed in seal computation
 - Add s10TransactionReference for Sips1 retro-compatibility
 - Fix payment response parameters type
 - Offesetted type zone are now correctly parsed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants