-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add support for other SIPS2 APIs #9
base: develop
Are you sure you want to change the base?
Conversation
- factorize common code in sdk-common - remove sdk-payment common No javadoc yet
…o worldline_develop � Conflicts: � payment-sdk/build.gradle
No javadoc yet
- Seal computation now sort all fields of a class hierarchy instead of sorting on each class - Fix broken seal calculator tests
Great work so far, @Jydett! Couple remarks up until now
|
Ok @CrlH thx for the feedback. A couple a unit tests and documentations and this should be ready to review :D On a side note are you interested to add github actions to this project ? (this could be done in another PR if you are interested) |
- fix javadoc - fix exception bad imports - remove unused code - add few tests - accept unknown response code
- fix javadoc - fix exception bad imports - remove unused code - add few tests - accept unknown response code
This si worth noting that this could be a major version since some imports and names changed |
I've updated the readme without changing the version number since I'm not sure how you want to bump the lib version with this PR |
- YearMonth is correctly parsed in seal computation - Add s10TransactionReference for Sips1 retro-compatibility - Fix payment response parameters type - Offesetted type zone are now correctly parsed
Fix payment test
Hi, this WIP PR adds support to others SIPS2 API (only Office -> wallet for now)
TODO
Feedback appreciated !