Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3_CD_CD #10

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

3_CD_CD #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f22df72
Modifications partie 1
cleo-demay Jan 30, 2023
3a8ecd0
Part 2 of XSS pw. Ready for PR
Jan 30, 2023
5907e4a
Merge pull request #1 from cleo-demay/part1
cleo-demay Jan 30, 2023
65b8192
Merge pull request #2 from cleo-demay/partie2
corentindessenne Jan 30, 2023
b40db37
Update home.ts
corentindessenne Feb 13, 2023
dcd4e19
Merge pull request #3 from cleo-demay/part2
corentindessenne Feb 13, 2023
e351be7
Update home.ts (last time i promise)
corentindessenne Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pw/pw-xss/client/src/app/home/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div>
<h1>{{message}}</h1>
<h1><a [href]="trustedUrl">{{message}}</a></h1>
<table class="k-data-table">
<caption>Latest news from Web &amp; Mobile Framework Team</caption>
<thead>
Expand All @@ -22,9 +22,9 @@ <h1>{{message}}</h1>
</tfoot>
<tbody>
<tr class="gradeA" *ngFor="let currentNew of news">
<td>{{currentNew.author}}</td>
<td>{{currentNew.category}}</td>
<td>{{currentNew.content}}</td>
<td [innerHtml] = 'currentNew.author' ></td>
<td [innerHtml] = 'currentNew.category'></td>>
<td [innerHtml] = 'currentNew.content'></td>
<td><button class="btn" (click)="addLike(currentNew)"><img src="assets/styles/ktheme/img/like.png" /> {{currentNew.likes}}</button></td>
<td><button class="btn" (click)="deleteNews(currentNew)"><img src="assets/styles/ktheme/img/delete.png"/></button></td>
</tr>
Expand All @@ -41,7 +41,7 @@ <h1>{{message}}</h1>
<section class="k-panel">
<h4 class="control"><a href="#">And the news of the day is...</a></h4>
<div class="content">
<p><i>{{newsOfTheDay.content}}</i> from <b>{{newsOfTheDay.author}}</b></p>
<p> <span [innerHTML]="newsOfTheDay.content"></span> from <b>{{newsOfTheDay.author}}</b></p>
</div>
</section>
</div>
10 changes: 5 additions & 5 deletions pw/pw-xss/client/src/app/home/home.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Observable } from 'rxjs';

import { NewsService } from '../services/newsService';
import { News } from '../beans/news';
// import {DomSanitizer} from '@angular/platform-browser'
import {DomSanitizer} from '@angular/platform-browser'

@Component({
selector: 'home',
Expand All @@ -15,17 +15,17 @@ export class Home implements OnInit {
news: News[] = [];
newsOfTheDay: News = {};
nextNews: News = {};
//trustedUrl: string;
trustedUrl: string = '';
constructor(
private newsService: NewsService,
// private sanitizer: DomSanitizer
private sanitizer: DomSanitizer
) {}

ngOnInit() {
// javascript: URLs are dangerous if attacker controlled.
// Angular sanitizes them in data binding, but you can
// explicitly tell Angular to trust this value:
//this.trustedUrl = <string> this.sanitizer.bypassSecurityTrustUrl('javascript:alert("Don\'t forget to add a comment in the bottom please!")');
this.trustedUrl = <string> this.sanitizer.bypassSecurityTrustUrl('javascript:alert("Don\'t forget to add a comment in the bottom please!")');
this.updateNews();
}

Expand All @@ -38,7 +38,7 @@ export class Home implements OnInit {
this.newsOfTheDay = news;
// uncomment the line below only for demo purpose, don't do this in a real situation
// if you want to force a given scripting which you trust and is under you strict control (never from user input), use DomSanitizer#bypassSecurityTrustHtml(String) method
//this.newsOfTheDay.content = <string> this.sanitizer.bypassSecurityTrustHtml(this.newsOfTheDay.content);
this.newsOfTheDay.content = <string> this.sanitizer.bypassSecurityTrustHtml('<button id="myButton" onclick="alert(\'Button was clicked!\')">Click Me!</button>');
});
}

Expand Down