Add instrumentation to tree_availability
#65
0xKitsuneAnnotations
2 errors and 10 warnings
|
an async construct yields a type which is itself awaitable:
crates/tree_availability/src/world_tree/mod.rs#L72
error: an async construct yields a type which is itself awaitable
--> crates/tree_availability/src/world_tree/mod.rs:72:59
|
69 | #[instrument(skip(self))]
| ------------------------- outer async construct
...
72 | ) -> JoinHandle<Result<(), TreeAvailabilityError<M>>> {
| ___________________________________________________________^
73 | | let tree_data = self.tree_data.clone();
74 | | let tree_updater = self.tree_updater.clone();
75 | |
... |
88 | | })
89 | | }
| |_____^ awaitable value not awaited
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#async_yields_async
= note: `#[deny(clippy::async_yields_async)]` on by default
help: consider awaiting this value
|
72 ~ ) -> JoinHandle<Result<(), TreeAvailabilityError<M>>> {
73 + let tree_data = self.tree_data.clone();
74 + let tree_updater = self.tree_updater.clone();
75 +
76 + tracing::info!("Spawning thread to sync tree");
77 + let synced = self.synced.clone();
78 +
79 + tokio::spawn(async move {
80 + tree_updater.sync_to_head(&tree_data).await?;
81 + synced.store(true, Ordering::Relaxed);
82 +
83 + loop {
84 + tree_updater.sync_to_head(&tree_data).await?;
85 +
86 + tokio::time::sleep(Duration::from_secs(5)).await;
87 + }
88 + })
89 + }.await
|
|
|
Lint
Clippy had exited with the 101 exit code
|
|
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/[email protected], actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|