Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NM Audit Fixes #118

Merged
merged 5 commits into from
Sep 7, 2023
Merged

NM Audit Fixes #118

merged 5 commits into from
Sep 7, 2023

Conversation

0xKitsune
Copy link
Contributor

This PR contains the fixes for the WorldIDIdentityManagerImplV1 mentioned in the NM-0126 notes.

@0xKitsune 0xKitsune marked this pull request as draft August 14, 2023 17:51
@0xKitsune 0xKitsune marked this pull request as ready for review August 14, 2023 19:23
@r3ld3v r3ld3v requested a review from Dzejkop August 14, 2023 22:19
@r3ld3v
Copy link

r3ld3v commented Aug 14, 2023

@Dzejkop you want to give this a quick review and then merge and test?

@Dzejkop
Copy link
Contributor

Dzejkop commented Aug 15, 2023

Looks good, maybe we can add a small unit test for the new error?

@dcbuild3r dcbuild3r merged commit 2f409a5 into main Sep 7, 2023
1 check passed
@dcbuild3r dcbuild3r deleted the 0xkitsune/nm-0126 branch September 7, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dzejkop Dzejkop Dzejkop approved these changes

@kustosz kustosz kustosz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xKitsune @r3ld3v @Dzejkop @kustosz @dcbuild3r