Skip to content

Commit

Permalink
Update virtual_person_id type to uint64. (#56)
Browse files Browse the repository at this point in the history
Currently the population_offset and total_population in VirtualPersonPool are uint64, while virtual_person_id in VirtualPersonActivity is int64. This could cause an issue when the range covered by virtual person pools is out of range of int64.

This is a safe change per https://developers.google.com/protocol-buffers/docs/proto#updating
  • Loading branch information
wliue authored Sep 16, 2022
1 parent 11375a3 commit 3a75214
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/proto/wfa/virtual_people/common/label.proto
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ message IndependentQuantumLabels {
message VirtualPersonActivity {
// If virtual_person_id is not set, then this is only for counting
// impressions by labels, and can be ignored for reach purpose.
optional int64 virtual_person_id = 1;
optional uint64 virtual_person_id = 1;

oneof person_label {
// Quantum label. This is only for debugging purposes.
Expand Down

0 comments on commit 3a75214

Please sign in to comment.