Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow swig files to include each other #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

efoxepstein
Copy link

@efoxepstein efoxepstein commented Jul 7, 2022

This adds the swig_includes option to java_wrap_cc to allow swig files to include other swig files.


This change is Reviewable

@efoxepstein efoxepstein requested a review from SanjayVas July 7, 2022 00:03
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)


java/defs.bzl line 133 at r1 (raw file):

        package,
        deps = [],
        swig_includes = [],

nit: this should be None.

We only use empty list when the macro needs to do something with the list. In the case of deps, it's because we concatenate it and another list.

Code quote:

 []

Copy link

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjayVas - are you planning on taking this pr over?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants