Update protobuf dep to 23.1. #4
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
MODULE.bazel line 22 at r1 (raw file):
bazel_dep( name = "rules_proto", version = "6.0.0-rc1",
whats the reason for adopting a release candidate here?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
MODULE.bazel line 22 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
whats the reason for adopting a release candidate here?
The latest official release is specifically tied to protobuf 21.7. The RC is known to be compatible with 23.1.
SanjayVas
force-pushed
the
sanjayvas-protobuf
branch
from
4623e5c to
ac87831
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
MODULE.bazel line 22 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
The latest official release is specifically tied to protobuf 21.7. The RC is known to be compatible with 23.1.
I'd prefer to be on 21.7 then until its not a rc unless we have a strong reason.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
MODULE.bazel line 22 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
I'd prefer to be on 21.7 then until its not a rc unless we have a strong reason.
We do. This is blocking upgrading gRPC and therefore adding Python gRPC support for planning. 21.7 is also ancient, released Sept of 2022. Even 23.1 is pretty old at May 2023 given that the latest is 25.2 released last week. 23.1 is the latest that's been published to the Bazel Central Registry, and therefore the latest that is known to work for rules_proto which already migrated.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
MODULE.bazel line 22 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
We do. This is blocking upgrading gRPC and therefore adding Python gRPC support for planning. 21.7 is also ancient, released Sept of 2022. Even 23.1 is pretty old at May 2023 given that the latest is 25.2 released last week. 23.1 is the latest that's been published to the Bazel Central Registry, and therefore the latest that is known to work for rules_proto which already migrated.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-protobuf
branch
from
ac87831 to
2493485
Compare
No description provided.