Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel version to 7.0.1 #198

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Update bazel version to 7.0.1 #198

merged 1 commit into from
Feb 5, 2024

Conversation

renjiezh
Copy link
Contributor

@renjiezh renjiezh commented Feb 2, 2024

No description provided.

@renjiezh renjiezh requested a review from SanjayVas February 2, 2024 22:43
@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh and @stevenwarejones)


.bazelversion line 1 at r1 (raw file):

7.0.1

nit: 7.0.2 just got released if you're updating anyway

Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

Copy link
Contributor Author

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)


.bazelversion line 1 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

nit: 7.0.2 just got released if you're updating anyway

I will keep it as 7.0.1 to be consistent with other repos.

@renjiezh renjiezh merged commit 4ea9cf7 into main Feb 5, 2024
4 checks passed
@renjiezh renjiezh deleted the bazel-version-7 branch February 5, 2024 17:51
SanjayVas added a commit that referenced this pull request Feb 13, 2024
This was missed as part of upgrading to Bazel 7 in #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants