add assign_join_key_ids step #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
CC @jonmolle
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
a discussion (no related file):
FYI I think you're getting an API lint error because Bazel 7 got launched and this repo doesn't have a .bazelversion file. The default behavior of Bazelisk is to grab the latest LTS release.
stevenwarejones
commented
Dec 20, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
stevenwarejones
added a commit
to world-federation-of-advertisers/cross-media-measurement
that referenced
this pull request
Dec 20, 2023
Adds a new step to input join keys without ids, shuffle those, and then add ids. This mitigates a security risk where the model provider may make mistakes like inputting alphabetized join key email addresses which over time will leak information across exchanges. Implements world-federation-of-advertisers/cross-media-measurement-api#194
ple13
pushed a commit
to world-federation-of-advertisers/cross-media-measurement
that referenced
this pull request
Aug 16, 2024
Adds a new step to input join keys without ids, shuffle those, and then add ids. This mitigates a security risk where the model provider may make mistakes like inputting alphabetized join key email addresses which over time will leak information across exchanges. Implements world-federation-of-advertisers/cross-media-measurement-api#194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One concern our security team had was there are various attacks if a MP doesn't shuffle their join key list each exchange. This adds a step to assign the ids to the join keys for the MP.