Add function to sample non zero random vector.

[ple13]

No description provided.

[wfa-reviewable]

This change is 

[SanjayVas]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @ple13, and @renjiezh)

---

src/main/cc/math/uniform_pseudorandom_generator.h line 50 at r1 (raw file):

      int64_t size, uint32_t modulus) = 0;

  // Generates uniformly random values in the range [1, modulus).

nit: shouldn't this have the same summary fragment as GenerateUniformRandomRange, only including the non-zero part?

[kungfucraig]

Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ple13 and @renjiezh)

[ple13]

Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @kungfucraig, @renjiezh, and @SanjayVas)

---

src/main/cc/math/uniform_pseudorandom_generator.h line 50 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

nit: shouldn't this have the same summary fragment as GenerateUniformRandomRange, only including the non-zero part?

Done.

[kungfucraig]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh, @SanjayVas, and @stevenwarejones)

[stevenwarejones]

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ple13, @renjiezh, and @SanjayVas)

---

src/main/cc/math/open_ssl_uniform_random_generator.cc line 166 at r2 (raw file):

  }

  if (size < 0) {

in what scenario is size == 0 valid?

[ple13]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh, @SanjayVas, and @stevenwarejones)

---

src/main/cc/math/open_ssl_uniform_random_generator.cc line 166 at r2 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

in what scenario is size == 0 valid?

Size = 0 is a singularity case, where the return is an empty array. I'm not sure if this will ever be used in practice, but it could happen when we call prng->GenerateNonZeroUniformRandomRange(otherArray.size()) where the otherArray is an empty one.

[renjiezh]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas and @stevenwarejones)

[stevenwarejones]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)