fix: TypeError: trim(): Argument #1 ($string) must be of type string,…

… null given
workbunny · Sep 24, 2024 · 188296d · 188296d
1 parent 794e7c8
commit 188296d
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Traits/RegistrarMethods.php b/src/Traits/RegistrarMethods.php
@@ -21,6 +21,10 @@ trait RegistrarMethods
 {
     protected ?int $registrarTimerId = null;
 
+    protected ?string $registrarHostIp = null;
+
+    protected ?int $registrarHostPort = null;
+
     /**
      * @return RegistrarInterface|null
      */
@@ -79,7 +83,7 @@ public function registrarStop(Worker $worker): void
      */
     public function registrarGetHostIp(): string
     {
-        return trim(shell_exec('curl -s ifconfig.me'));
+        return $this->registrarHostIp ?: ($this->registrarHostIp = trim(shell_exec('curl -s ifconfig.me')));
     }
 
     /**
@@ -88,7 +92,7 @@ public function registrarGetHostIp(): string
     public function registrarGetHostPort(): ?int
     {
         $serverName = static::getServerName();
-        return config("plugin.workbunny.webman-push-server.app.$serverName.port");
+        return $this->registrarHostPort ?: ($this->registrarHostPort = config("plugin.workbunny.webman-push-server.app.$serverName.port"));
     }
 
     /**