Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to Twitter provider when embedding X URLs #6239

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Fallback to Twitter provider when embedding X URLs #6239

merged 2 commits into from
Sep 27, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Sep 27, 2023 •
edited
Loading

Related PRs:

Use Twitter provider when embedding X URLs (e.g. https://x.com/automattic/status/1395447061336711181).

To test:
Follow the testing instructions from WordPress/gutenberg#54876.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Bug Something isn't working label Sep 27, 2023
@fluiddot fluiddot added this to the 1.105.0 (23.4) milestone Sep 27, 2023
@fluiddot fluiddot requested a review from SiobhyB September 27, 2023 17:16
@fluiddot fluiddot self-assigned this Sep 27, 2023
@fluiddot fluiddot requested a review from derekblank September 27, 2023 17:19
SiobhyB
SiobhyB approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved via WordPress/gutenberg#54876 (review).

@fluiddot fluiddot enabled auto-merge September 27, 2023 17:21
@fluiddot fluiddot merged commit 8a980d2 into trunk Sep 27, 2023
1 check passed
@fluiddot fluiddot deleted the fix/embed-block-x-twitter-preview branch September 27, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiobhyB SiobhyB SiobhyB approved these changes

@derekblank derekblank Awaiting requested review from derekblank

Assignees

@fluiddot fluiddot

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.105.0 (23.4)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @SiobhyB