-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .ruby-version to 3.2.2 #6180
Conversation
@mokagio Also updating the Ruby version here. I noted that the CI was failing with:
I then noted that the release-toolkit CHANGELOG drops the dependency on bigdecimal and supports Ruby 3 in version 9.0+, so I updated |
It looks like WordPress iOS uses version |
@@ -676,4 +676,4 @@ SPEC CHECKSUMS: | |||
|
|||
PODFILE CHECKSUM: 1caec69a3de9c6e37113c8eb5dbdb2d2b52c5108 | |||
|
|||
COCOAPODS: 1.12.1 | |||
COCOAPODS: 1.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change needed? I see we use 1.12.1
in WordPress iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was the output of running bundle exec pod install
(which was a command prompted by CI failures). 1.13.0 refers to the latest Cocoapods release, and 1.12.1 was the previous version. I'm not certain if they need to be consistent with WordPress iOS either.
@mokagio Any issues with using fastlane-plugin-wpmreleasetoolkit 9.1.0 or Cocoapods 1.13.0 here? Or should we use 9.0 and 1.12.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay to use 1.13.0 here. We don't need to keep the versions in sync between projects because:
- Fastlane is used for project automation, there is no information exchanged between the two setup.
- CocoaPods is used to put together dependencies and generate a binary framework. It's highly unlikely that a difference in the library version will result in issues.
Anyways, we'll soon update CocoaPods to version 1.13.0 in WordPress iOS, too, given it has a fix for Xcode 15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also wanted to say that updating the release-toolkit to 9.x was the "correct" thing to do in this case because that's the version officially compatible with Ruby 3 👍 Thanks @derekblank
@SiobhyB the branch was a bit out of date which is why it was blocked by a CI task not having reported. I merged the latest |
Hey @derekblank 👋 I think it'd be a good idea to bring the changes merged in WordPress/gutenberg#54897 to Gutenberg mobile so both repos are synced. |
@geriux Thanks! Updated here: |
Ruby was updated from
2.7.4
to3.2.2
in the iOS codebase in wordpress-mobile/WordPress-iOS#21498. This PR brings Gutenberg Mobile in alignment with that change.Related:
To test:
PR submission checklist: