Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .ruby-version to 3.2.2 #6180

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Update .ruby-version to 3.2.2 #6180

merged 4 commits into from
Oct 4, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Sep 11, 2023

Ruby was updated from 2.7.4 to 3.2.2 in the iOS codebase in wordpress-mobile/WordPress-iOS#21498. This PR brings Gutenberg Mobile in alignment with that change.

Related:

To test:

  • Verify CI tests pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@derekblank
Copy link
Contributor

@mokagio Also updating the Ruby version here. I noted that the CI was failing with:

An error occurred while installing bigdecimal (1.4.4), and Bundler cannot continue.

In Gemfile:
  fastlane-plugin-wpmreleasetoolkit was resolved to 8.1.0, which depends on
    bigdecimal

I then noted that the release-toolkit CHANGELOG drops the dependency on bigdecimal and supports Ruby 3 in version 9.0+, so I updated fastlane-plugin-wpmreleasetoolkit to 9.1.0 here. Let me know if there is a reason not to do so, or if there is anything else we should update within the Gutenberg XCFramework here.

@derekblank derekblank marked this pull request as ready for review October 3, 2023 03:02
@derekblank derekblank requested a review from mokagio October 3, 2023 03:02
@derekblank derekblank requested a review from geriux October 3, 2023 06:35
@geriux
Copy link
Contributor

geriux commented Oct 3, 2023

@mokagio Also updating the Ruby version here. I noted that the CI was failing with:

An error occurred while installing bigdecimal (1.4.4), and Bundler cannot continue.

In Gemfile:
  fastlane-plugin-wpmreleasetoolkit was resolved to 8.1.0, which depends on
    bigdecimal

I then noted that the release-toolkit CHANGELOG drops the dependency on bigdecimal and supports Ruby 3 in version 9.0+, so I updated fastlane-plugin-wpmreleasetoolkit to 9.1.0 here. Let me know if there is a reason not to do so, or if there is anything else we should update within the Gutenberg XCFramework here.

It looks like WordPress iOS uses version 9.0 not sure if they need to be consistent or not 🤔

@@ -676,4 +676,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: 1caec69a3de9c6e37113c8eb5dbdb2d2b52c5108

COCOAPODS: 1.12.1
COCOAPODS: 1.13.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change needed? I see we use 1.12.1 in WordPress iOS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was the output of running bundle exec pod install (which was a command prompted by CI failures). 1.13.0 refers to the latest Cocoapods release, and 1.12.1 was the previous version. I'm not certain if they need to be consistent with WordPress iOS either.

@mokagio Any issues with using fastlane-plugin-wpmreleasetoolkit 9.1.0 or Cocoapods 1.13.0 here? Or should we use 9.0 and 1.12.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to use 1.13.0 here. We don't need to keep the versions in sync between projects because:

  1. Fastlane is used for project automation, there is no information exchanged between the two setup.
  2. CocoaPods is used to put together dependencies and generate a binary framework. It's highly unlikely that a difference in the library version will result in issues.

Anyways, we'll soon update CocoaPods to version 1.13.0 in WordPress iOS, too, given it has a fix for Xcode 15.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also wanted to say that updating the release-toolkit to 9.x was the "correct" thing to do in this case because that's the version officially compatible with Ruby 3 👍 Thanks @derekblank

@mokagio
Copy link
Contributor

mokagio commented Oct 4, 2023

Screenshot 2023-10-04 at 12 28 19 pm

@SiobhyB the branch was a bit out of date which is why it was blocked by a CI task not having reported. I merged the latest trunk which should sort that out.

@derekblank derekblank merged commit e43608e into trunk Oct 4, 2023
@derekblank derekblank deleted the update/ruby-version branch October 4, 2023 03:12
@geriux geriux added this to the 1.106.0 (23.5) milestone Oct 4, 2023
@geriux
Copy link
Contributor

geriux commented Oct 4, 2023

Hey @derekblank 👋 I think it'd be a good idea to bring the changes merged in WordPress/gutenberg#54897 to Gutenberg mobile so both repos are synced.

@derekblank
Copy link
Contributor

Hey @derekblank 👋 I think it'd be a good idea to bring the changes merged in WordPress/gutenberg#54897 to Gutenberg mobile so both repos are synced.

@geriux Thanks! Updated here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants