Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename snapshot tests. #6169

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Rename snapshot tests. #6169

merged 1 commit into from
Sep 7, 2023

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Sep 7, 2023

Updates the filenames for snapshot tests located in __device-tests__/image-snapshots:

for f in *sanity*; do git mv "$f" "$(echo "$f" | sed 's/sanity/functionality/g')"; done

This is a follow up to #6164.

To test:

  • Ensure CI doesn't fail

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes mentioned this pull request Sep 7, 2023
2 tasks
@twstokes
Copy link
Contributor Author

twstokes commented Sep 7, 2023

On this PR I'll trigger the full tests. 👍

@twstokes twstokes added this to the 1.104.0 (23.3) milestone Sep 7, 2023
@twstokes twstokes self-assigned this Sep 7, 2023
@twstokes twstokes requested review from SiobhyB and fluiddot September 7, 2023 17:35
@twstokes twstokes added the Testing Anything related to automated tests label Sep 7, 2023
@twstokes
Copy link
Contributor Author

twstokes commented Sep 7, 2023

@fluiddot and @SiobhyB - would you mind giving this PR a look? All tests including the optional ones seem to have passed. Thanks!

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@twstokes twstokes merged commit 78afbeb into trunk Sep 7, 2023
1 check passed
@twstokes twstokes deleted the tests/functionality-snapshots branch September 7, 2023 18:04
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot and @SiobhyB - would you mind giving this PR a look? All tests including the optional ones seem to have passed. Thanks!

I saw the PR is already merged, so I'm leaving my approval as a comment. LGTM 🎊 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants