Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gutenberg submodule and fix List block's e2e test #3014

Merged
merged 3 commits into from
Jan 18, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 18, 2021

gutenberg PR: WordPress/gutenberg#28286

Description

This PR updates the Gutenberg submodule with the latest changes from master (commit: 04f9757) and includes the fix for List block's e2e test (commit: 82bdf9d).

How has this been tested?

This PR can be tested by running the List block's e2e test for each platform:

  1. For Android run: npm run test:e2e:android:local gutenberg-editor-lists-@canary
  2. For iOS run: npm run test:e2e:ios:local gutenberg-editor-lists-@canary

For more information about running e2e tests, check UI tests instructions (aka e2e tests).

These changes are also tested in the following PR checks:

  • ci/circleci: Test Android
  • ci/circleci: Test Android on Device - Canaries
  • ci/circleci: Test iOS
  • ci/circleci: Test iOS on Device - Canaries

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 18, 2021
@fluiddot fluiddot requested a review from hypest January 18, 2021 12:54
@fluiddot fluiddot changed the title Bump Gutenberg submodule Bump Gutenberg submodule and fix List block's e2e test Jan 18, 2021
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run the iOS e2e tests successfully locally using Xcode 12.2. In Slack, Stefanos said he had passing tests for Android locally.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@cameronvoell cameronvoell merged commit c73ba02 into develop Jan 18, 2021
@cameronvoell cameronvoell deleted the dependency/bump-gutenberg-82bdf9d branch January 18, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants