Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from GB master #25

Merged
merged 10 commits into from
Mar 30, 2018
Merged

Update from GB master #25

merged 10 commits into from
Mar 30, 2018

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Mar 28, 2018

To test: app, tests and flow should all run fine.

@hypest
Copy link
Contributor Author

hypest commented Mar 29, 2018

It's unfortunate I can't replicate the Tests error happening on Travis. App and tests run fine locally :(

I ended up adding react-dom as a dev dependency to please the Jest tests running on Travis but, it would be better if I could find out why the tests pass locally.

On the bright side, both the GB build+tests and the RN build+tests are now ✅.

@hypest hypest force-pushed the feature/update-from-gb-master branch from f2311db to 0a206e8 Compare March 29, 2018 14:24
@maxme
Copy link
Contributor

maxme commented Mar 30, 2018

yarn test-debug: ✅ (after connecting the react dev tools)
yarn test: ✅

:shipit:

@maxme maxme merged commit 2a6b6f3 into master Mar 30, 2018
@maxme maxme deleted the feature/update-from-gb-master branch March 30, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants