Release v1.26.0 (#2153)

* Add tests for Latest-Posts Bock * Have the Automation tests Scroll the Block window to help locate Block buttons on Android * Update gutenberg reference * Update Gutenberg ref * Update Gutenberg ref * New template for release PRs This PR will add a new template for release PRs to make it easier to check all the steps needed and to standardize the release PRs. This template can then be used by using this link: `https://github.com/wordpress-mobile/gutenberg-mobile/pull/new?template=release_pull_request.md` * Update template file. * Fix: remove extra padding for post title and first `Paragraph` block (#2095) * Fix: remove extra padding for post title and first `Paragraph` block * Update Gutenberg ref * Add a new androidReplacements function to comply with Android Typography lint rules * Make sure the file gutenberg.pot exists before generating android and ios strings. * Update Gutenberg ref * Update gutenberg ref * Update gutenberg ref * Update gutenberg reference * Gutenberg update * Update Gutenberg ref * Update Gutenberg ref * Update Gutenberg ref * Update Gutenberg ref * Fix: prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS (#2023) * prevent ripple effect on slider cell in BottomSheet and disable it completely on iOS * Update Gutenberg ref * Update Gutenberg ref * Accept multiple headers through OnAuthHeaderRequestedListener (#2080) * Blog layout template (#2114) * Update Gutenberg ref * Update Gutenberg ref * Update gutenberg reference * Fix failing UI tests Try scrolling in the Inserter for all platforms * Disable the failing test on iOS Co-authored-by: Matthew Kevins <[email protected]> Co-authored-by: Pinar Olguc <[email protected]> * Update gutenberg reference * Feat: Column block (#1661) * update ref to master (Columns Block) * Update gutenberg reference * Fix Latests Posts Tests by expanding the scroll to button functionality * Fix lint issue * Fix typography breakage in master To a version where the typography panel is not added to block settings. * Update GB reference. * Correct slider step value (#2119) * Update ref: Correct slider step accordingly to the platform * Update gb ref Co-authored-by: Pinar Olguc <[email protected]> * v1.26.0 * Add some missing release notes * Update Podfile.lock * Update gb ref * Update bundles Co-authored-by: Chip Snyder <[email protected]> Co-authored-by: Matthew Kevins <[email protected]> Co-authored-by: Gerardo Pacheco <[email protected]> Co-authored-by: Sérgio Estêvão <[email protected]> Co-authored-by: jbinda <[email protected]> Co-authored-by: Chip <[email protected]> Co-authored-by: Maxime Biais <[email protected]> Co-authored-by: Tugdual de Kerviler <[email protected]> Co-authored-by: Klymentiy Haykov <[email protected]> Co-authored-by: Matthew Kevins <[email protected]> Co-authored-by: Luke Walczak <[email protected]>
wordpress-mobile · Apr 16, 2020 · 315a213 · 315a213
1 parent e75a227
commit 315a213
Show file tree

Hide file tree

Showing 36 changed files with 2,460 additions and 2,283 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE/release_pull_request.md b/.github/PULL_REQUEST_TEMPLATE/release_pull_request.md
@@ -0,0 +1,38 @@
+Release for Gutenberg Mobile v1.XX.Y
+
+## Related PRs
+
+- Gutenberg: https://github.com/WordPress/gutenberg/pull/
+- WPAndroid: https://github.com/wordpress-mobile/WordPress-Android/pull/
+- WPiOS: https://github.com/wordpress-mobile/WordPress-iOS/pull/
+
+- Aztec-iOS: https://github.com/wordpress-mobile/AztecEditor-iOS/pull/
+- Aztec-Android: https://github.com/wordpress-mobile/AztecEditor-Android/pull
+
+## Extra PRs that Landed After the Release Was Cut
+
+- [ ]  PR 1
+- [ ]  PR 2
+
+## Changes
+<!-- To determine the changes you can check the RELEASE-NOTES.txt file and cross check with the list of commits that are part of the PR -->
+
+ - Change 1
+ - Change 2
+
+## Test plan
+
+- Use the main WP apps to test the changes above. 
+- Check WPAndroid and WPiOS PRs if there are specific tests to run.
+- Smoke test the main WP apps for [general writing flow](https://github.com/wordpress-mobile/test-cases/tree/master/test-cases/gutenberg/writing-flow).
+
+## Release Submission Checklist
+
+- [ ] Release number was bumped
+- [ ] Aztec dependencies are pointing to a stable release
+  - iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'
+  - Android: 'grep aztecVersion react-native-aztec/android/build.gradle'
+- [ ] Gutenberg 'Podfile' and 'Podfile.lock' inside './ios/' are updated to the release number
+- [ ] Bundle package of the release is updated 
+- [ ] Check if `RELEASE-NOTES.txt` is updated with all the changes that made it to the release
+
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
@@ -1,3 +1,12 @@
+1.26.0
+------
+* [iOS] Disable ripple effect in all BottomSheet's controls.
+* [Android] Disable ripple effect for Slider control
+* New block: Columns
+* New starter page template: Blog
+* Make Starter Page Template picker buttons visible only when the screen height is enough
+* Fix a bug which caused to show URL settings modal randomly when changing the device orientation multiple times during the time Starter Page Template Preview is open
+
 1.25.0
 ------
 * New block: Cover

diff --git a/__device-tests__/gutenberg-editor-latest-posts.test.js b/__device-tests__/gutenberg-editor-latest-posts.test.js
@@ -0,0 +1,56 @@
+/**
+ * @format
+ * */
+
+/**
+ * Internal dependencies
+ */
+import EditorPage from './pages/editor-page';
+import {
+	setupDriver,
+	isLocalEnvironment,
+	stopDriver,
+} from './helpers/utils';
+
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000000;
+
+describe( 'Gutenberg Editor Latest Post Block tests', () => {
+	let driver;
+	let editorPage;
+	let allPassed = true;
+
+	// Use reporter for setting status for saucelabs Job
+	if ( ! isLocalEnvironment() ) {
+		const reporter = {
+			specDone: async ( result ) => {
+				allPassed = allPassed && result.status !== 'failed';
+			},
+		};
+
+		jasmine.getEnv().addReporter( reporter );
+	}
+
+	beforeAll( async () => {
+		driver = await setupDriver();
+		editorPage = new EditorPage( driver );
+	} );
+
+	it( 'should be able to see visual editor', async () => {
+		await expect( editorPage.getBlockList() ).resolves.toBe( true );
+	} );
+
+	it( 'should be able to add a Latests-Posts block', async () => {
+		await editorPage.addNewLatestPostsBlock();
+		const latestPostsBlock = await editorPage.getLatestPostsBlockAtPosition( 1 );
+
+		expect( latestPostsBlock ).toBeTruthy();
+		await editorPage.removeLatestPostsBlockAtPosition( 1 );
+	} );
+
+	afterAll( async () => {
+		if ( ! isLocalEnvironment() ) {
+			driver.sauceJobStatus( allPassed );
+		}
+		await stopDriver( driver );
+	} );
+} );
diff --git a/__device-tests__/pages/editor-page.js b/__device-tests__/pages/editor-page.js
@@ -21,6 +21,7 @@ export default class EditorPage {
 	headingBlockName = 'Heading';
 	imageBlockName = 'Image';
 	galleryBlockName = 'Gallery';
+	latestPostsBlockName = 'Latest Posts';
 	unorderedListButtonName = 'Convert to unordered list';
 	orderedListButtonName = 'Convert to ordered list';
 
@@ -161,8 +162,34 @@ export default class EditorPage {
 		await addButton.click();
 
 		// Click on block of choice
+		const blockButton = await this.findBlockButton( blockName );
+		if ( isAndroid() ) {
+			await blockButton.click();
+		} else {
+			await this.driver.execute( 'mobile: tap', { element: blockButton, x: 10, y: 10 } );
+		}
+	}
+
+	// Attempts to find the given block button in the block inserter control.
+	async findBlockButton( blockName: string ) {
+		if ( isAndroid() ) {
+			// Checks if the Block Button is available, and if not will scroll to the second half of the available buttons.
+			while ( ! await this.driver.hasElementByAccessibilityId( blockName ) ) {
+				await this.driver.pressKeycode( 20 ); // Press the Down arrow to force a scroll.
+			}
+
+			return await this.driver.elementByAccessibilityId( blockName );
+		}
+
 		const blockButton = await this.driver.elementByAccessibilityId( blockName );
-		await blockButton.click();
+		const size = await this.driver.getWindowSize();
+		const height = size.height - 5;
+
+		while ( ! await blockButton.isDisplayed() ) {
+			await this.driver.execute( 'mobile: dragFromToForDuration', { fromX: 50, fromY: height, toX: 50, toY: height - 450, duration: 0.5 } );
+		}
+
+		return blockButton;
 	}
 
 	async clickToolBarButton( buttonName: string ) {
@@ -432,4 +459,20 @@ export default class EditorPage {
 		const text = await textViewElement.text();
 		return text.toString();
 	}
+
+	// ============================
+	// Latest-Posts Block functions
+	// ============================
+
+	async addNewLatestPostsBlock() {
+		await this.addNewBlock( this.latestPostsBlockName );
+	}
+
+	async getLatestPostsBlockAtPosition( position: number ) {
+		return this.getBlockAtPosition( position, this.latestPostsBlockName );
+	}
+
+	async removeLatestPostsBlockAtPosition( position: number ) {
+		return await this.removeBlockAtPosition( position, this.latestPostsBlockName );
+	}
 }
diff --git a/bin/po2android.js b/bin/po2android.js
@@ -33,6 +33,21 @@ function escapeResourceXML( unsafeXMLValue ) {
 	} );
 }
 
+/**
+ * Android specifics replacements.
+ *
+ * @param {string} XMLValue input to apply replacements.
+ * @return {string} valid string passing Android linter rules.
+ */
+function androidReplacements( XMLValue ) {
+	return XMLValue.replace( /(-|\.\.\.)/gm, function( character ) {
+		switch ( character ) {
+			case '-': return '–'; // Android lint rule: TypographyDashes.
+			case '...': return '…'; // Android lint rule: TypographyEllipsis
+		}
+	} );
+}
+
 /**
  * Generate a unique string identifier to use as the `name` property in our xml.
  * Try using the string first by stripping any non-alphanumeric characters and cropping it
@@ -74,8 +89,8 @@ function po2Android( poInput ) {
 			return result;
 		}
 		const uniqueName = getUniqueName( translation.msgid );
-		const escapedValue = escapeResourceXML( translation.msgid );
-		const escapedValuePlural = escapeResourceXML( translation.msgid_plural || '' );
+		const escapedValue = androidReplacements( escapeResourceXML( translation.msgid ) );
+		const escapedValuePlural = androidReplacements( escapeResourceXML( translation.msgid_plural || '' ) );
 		const comment = translation.comments.extracted || '';
 		let localizedEntry = '';
 		if ( comment ) {

diff --git a/bundle/android/App.js b/bundle/android/App.js
diff --git a/bundle/android/App.js.map b/bundle/android/App.js.map
diff --git a/bundle/android/raw/gutenberg_packages_blocklibrary_src_button_block.json b/bundle/android/raw/gutenberg_packages_blocklibrary_src_button_block.json
@@ -19,18 +19,6 @@
 			"source": "html",
 			"selector": "a"
 		},
-		"backgroundColor": {
-			"type": "string"
-		},
-		"textColor": {
-			"type": "string"
-		},
-		"customBackgroundColor": {
-			"type": "string"
-		},
-		"customTextColor": {
-			"type": "string"
-		},
 		"linkTarget": {
 			"type": "string",
 			"source": "attribute",
@@ -48,12 +36,6 @@
 		},
 		"borderRadius": {
 			"type": "number"
-		},
-		"gradient": {
-			"type": "string"
-		},
-		"customGradient": {
-			"type": "string"
 		}
 	}
 }
diff --git a/bundle/android/raw/gutenberg_packages_blocklibrary_src_paragraph_block.json b/bundle/android/raw/gutenberg_packages_blocklibrary_src_paragraph_block.json
@@ -18,12 +18,6 @@
 		"placeholder": {
 			"type": "string"
 		},
-		"fontSize": {
-			"type": "string"
-		},
-		"customFontSize": {
-			"type": "number"
-		},
 		"direction": {
 			"type": "string",
 			"enum": [

diff --git a/bundle/android/raw/i18ncache_data_de.json b/bundle/android/raw/i18ncache_data_de.json
diff --git a/bundle/android/raw/i18ncache_data_es.json b/bundle/android/raw/i18ncache_data_es.json
diff --git a/bundle/android/raw/i18ncache_data_ro.json b/bundle/android/raw/i18ncache_data_ro.json
diff --git a/bundle/android/raw/i18ncache_data_sk.json b/bundle/android/raw/i18ncache_data_sk.json
diff --git a/bundle/android/raw/i18ncache_data_sq.json b/bundle/android/raw/i18ncache_data_sq.json
diff --git a/bundle/android/raw/i18ncache_data_sv.json b/bundle/android/raw/i18ncache_data_sv.json
diff --git a/bundle/android/raw/i18ncache_data_tr.json b/bundle/android/raw/i18ncache_data_tr.json
diff --git a/bundle/android/strings.xml b/bundle/android/strings.xml
@@ -5,7 +5,7 @@
     <!-- translators: sample content for "Contact" page template -->
     <string name="gutenberg_native_10_street_road" tools:ignore="UnusedResources">10 Street Road</string>
     <!-- translators: sample content for "Contact" page template -->
-    <string name="gutenberg_native_555_555_1234" tools:ignore="UnusedResources">(555)555-1234</string>
+    <string name="gutenberg_native_555_555_1234" tools:ignore="UnusedResources">(555)555–1234</string>
     <!-- translators: sample content for "Portfolio" page template -->
     <string name="gutenberg_native_a_description_of_the_project_and_the_works_presented" tools:ignore="UnusedResources">A description of the project and the works presented.</string>
     <!-- translators: sample content for "Contact" page template -->
@@ -31,7 +31,8 @@
     <string name="gutenberg_native_alt_text" tools:ignore="UnusedResources">Alt Text</string>
     <string name="gutenberg_native_an_unknown_error_occurred_please_try_again" tools:ignore="UnusedResources">An unknown error occurred. Please try again.</string>
     <string name="gutenberg_native_annotations_sidebar" tools:ignore="UnusedResources">Annotations Sidebar</string>
-    <string name="gutenberg_native_background_opacity" tools:ignore="UnusedResources">Background Opacity</string>
+    <!-- translators: title for "Blog" page template -->
+    <string name="gutenberg_native_blog" tools:ignore="UnusedResources">Blog</string>
     <string name="gutenberg_native_border_radius" tools:ignore="UnusedResources">Border Radius</string>
     <string name="gutenberg_native_border_settings" tools:ignore="UnusedResources">Border Settings</string>
     <string name="gutenberg_native_button_color_settings_are_coming_soon" tools:ignore="UnusedResources">Button color settings are coming soon.</string>
@@ -40,7 +41,10 @@
     <!-- translators: sample content for "Contact" page template -->
     <string name="gutenberg_native_city_10100" tools:ignore="UnusedResources">City, 10100</string>
     <string name="gutenberg_native_clear_all_settings" tools:ignore="UnusedResources">Clear All Settings</string>
+    <string name="gutenberg_native_color_settings_are_coming_soon" tools:ignore="UnusedResources">Color settings are coming soon.</string>
+    <string name="gutenberg_native_columns_settings" tools:ignore="UnusedResources">Columns Settings</string>
     <string name="gutenberg_native_content" tools:ignore="UnusedResources">Content…</string>
+    <!-- translators: %s: current cell value. -->
     <string name="gutenberg_native_current_value_is_s" tools:ignore="UnusedResources">Current value is %s</string>
     <string name="gutenberg_native_customize" tools:ignore="UnusedResources">CUSTOMIZE</string>
     <!-- translators: sample content for "About" page template -->
@@ -52,6 +56,8 @@
     <!-- translators: accessibility text -->
     <string name="gutenberg_native_double_tap_to_edit_this_value" tools:ignore="UnusedResources">Double tap to edit this value</string>
     <string name="gutenberg_native_double_tap_to_move_the_block_down" tools:ignore="UnusedResources">Double tap to move the block down</string>
+    <string name="gutenberg_native_double_tap_to_move_the_block_to_the_left" tools:ignore="UnusedResources">Double tap to move the block to the left</string>
+    <string name="gutenberg_native_double_tap_to_move_the_block_to_the_right" tools:ignore="UnusedResources">Double tap to move the block to the right</string>
     <string name="gutenberg_native_double_tap_to_move_the_block_up" tools:ignore="UnusedResources">Double tap to move the block up</string>
     <string name="gutenberg_native_double_tap_to_redo_last_change" tools:ignore="UnusedResources">Double tap to redo last change</string>
     <string name="gutenberg_native_double_tap_to_remove_the_block" tools:ignore="UnusedResources">Double tap to remove the block</string>
@@ -64,13 +70,14 @@
     <string name="gutenberg_native_double_tap_to_undo_last_change" tools:ignore="UnusedResources">Double tap to undo last change</string>
     <!-- translators: sample content for "About" page template -->
     <string name="gutenberg_native_dr_seuss" tools:ignore="UnusedResources">Dr. Seuss</string>
-    <string name="gutenberg_native_edit_cover_media" tools:ignore="UnusedResources">Edit cover media</string>
     <string name="gutenberg_native_edit_media" tools:ignore="UnusedResources">Edit media</string>
     <string name="gutenberg_native_edit_video" tools:ignore="UnusedResources">Edit video</string>
     <!-- translators: sample content for "Team" page template -->
     <string name="gutenberg_native_email_me_a_href_mailto_mail_example_com_mail_example_com_a" tools:ignore="UnusedResources">Email me: &lt;a href=\"mailto:[email protected]\"&gt;[email protected]&lt;/a&gt;</string>
     <string name="gutenberg_native_excerpt_length_words" tools:ignore="UnusedResources">Excerpt length (words)</string>
     <string name="gutenberg_native_failed_to_insert_media_please_tap_for_options" tools:ignore="UnusedResources">Failed to insert media.\nPlease tap for options.</string>
+    <!-- translators: sample content for "Blog" page template -->
+    <string name="gutenberg_native_follow_our_blog" tools:ignore="UnusedResources">Follow our Blog</string>
     <!-- translators: accessibility text. %s: gallery caption. -->
     <string name="gutenberg_native_gallery_caption_s" tools:ignore="UnusedResources">Gallery caption. %s</string>
     <!-- translators: sample content for "About" page template
@@ -94,6 +101,8 @@ translators: sample content for "Services" page template -->
     <string name="gutenberg_native_j_k_rowling" tools:ignore="UnusedResources">J.K. Rowling</string>
     <!-- translators: sample content for "Team" page template -->
     <string name="gutenberg_native_juan_p_rez" tools:ignore="UnusedResources">Juan Pérez</string>
+    <!-- translators: sample content for "Blog" page template -->
+    <string name="gutenberg_native_latest_blog_posts" tools:ignore="UnusedResources">Latest Blog Posts</string>
     <!-- translators: sample content for "About" page template -->
     <string name="gutenberg_native_let_s_build_something_together" tools:ignore="UnusedResources">Let’s build something together</string>
     <!-- translators: sample content for "Services" page template -->
@@ -106,10 +115,15 @@ translators: sample content for "Services" page template -->
     <string name="gutenberg_native_link_settings" tools:ignore="UnusedResources">Link Settings</string>
     <string name="gutenberg_native_link_text" tools:ignore="UnusedResources">Link text</string>
     <string name="gutenberg_native_link_to" tools:ignore="UnusedResources">Link To</string>
-    <string name="gutenberg_native_minimum_height_in_pixels" tools:ignore="UnusedResources">Minimum height in pixels</string>
     <string name="gutenberg_native_move_block_down" tools:ignore="UnusedResources">Move block down</string>
     <!-- translators: accessibility text. %1: current block position (number). %2: next block position (number) -->
     <string name="gutenberg_native_move_block_down_from_row_1_s_to_row_2_s" tools:ignore="UnusedResources">Move block down from row %1$s to row %2$s</string>
+    <string name="gutenberg_native_move_block_left" tools:ignore="UnusedResources">Move block left</string>
+    <!-- translators: accessibility text. %1: current block position (number). %2: next block position (number) -->
+    <string name="gutenberg_native_move_block_left_from_position_1_s_to_position_2_s" tools:ignore="UnusedResources">Move block left from position %1$s to position %2$s</string>
+    <string name="gutenberg_native_move_block_right" tools:ignore="UnusedResources">Move block right</string>
+    <!-- translators: accessibility text. %1: current block position (number). %2: next block position (number) -->
+    <string name="gutenberg_native_move_block_right_from_position_1_s_to_position_2_s" tools:ignore="UnusedResources">Move block right from position %1$s to position %2$s</string>
     <string name="gutenberg_native_move_block_up" tools:ignore="UnusedResources">Move block up</string>
     <!-- translators: accessibility text. %1: current block position (number). %2: next block position (number) -->
     <string name="gutenberg_native_move_block_up_from_row_1_s_to_row_2_s" tools:ignore="UnusedResources">Move block up from row %1$s to row %2$s</string>
@@ -123,6 +137,7 @@ translators: sample content for "Services" page template -->
     <string name="gutenberg_native_my_pre_publish_panel" tools:ignore="UnusedResources">My pre publish panel</string>
     <string name="gutenberg_native_navigate_up" tools:ignore="UnusedResources">Navigate Up</string>
     <string name="gutenberg_native_no_application_can_handle_this_request_please_install_a_web_brows" tools:ignore="UnusedResources">No application can handle this request. Please install a Web browser.</string>
+    <string name="gutenberg_native_number_of_columns" tools:ignore="UnusedResources">Number of columns</string>
     <string name="gutenberg_native_only_show_excerpt" tools:ignore="UnusedResources">Only show excerpt</string>
     <string name="gutenberg_native_open_settings" tools:ignore="UnusedResources">Open Settings</string>
     <!-- translators: accessibility text. %s: Page break text. -->
@@ -150,7 +165,9 @@ translators: sample content for "Services" page template -->
     <string name="gutenberg_native_s_block_empty" tools:ignore="UnusedResources">%s block. Empty</string>
     <!-- translators: accessibility text for blocks with invalid content. %d: localized block title -->
     <string name="gutenberg_native_s_block_this_block_has_invalid_content" tools:ignore="UnusedResources">%s block. This block has invalid content</string>
+    <!-- translators: %s: Name of the block -->
     <string name="gutenberg_native_s_isn_t_yet_supported_on_wordpress_for_android" tools:ignore="UnusedResources">\'%s\' isn\'t yet supported on WordPress for Android</string>
+    <!-- translators: %s: Name of the block -->
     <string name="gutenberg_native_s_isn_t_yet_supported_on_wordpress_for_ios" tools:ignore="UnusedResources">\'%s\' isn\'t yet supported on WordPress for iOS</string>
     <!-- translators: sample content for "Team" page template -->
     <string name="gutenberg_native_sally_smith" tools:ignore="UnusedResources">Sally Smith</string>
@@ -166,6 +183,8 @@ translators: sample content for "Services" page template -->
     <string name="gutenberg_native_start_writing" tools:ignore="UnusedResources">Start writing…</string>
     <!-- translators: sample content for "Services" page template -->
     <string name="gutenberg_native_strategy" tools:ignore="UnusedResources">Strategy</string>
+    <!-- translators: sample content for "Blog" page template -->
+    <string name="gutenberg_native_subscribe" tools:ignore="UnusedResources">Subscribe</string>
     <string name="gutenberg_native_success_message" tools:ignore="UnusedResources">Success Message</string>
     <string name="gutenberg_native_take_a_photo" tools:ignore="UnusedResources">Take a Photo</string>
     <string name="gutenberg_native_take_a_photo_or_video" tools:ignore="UnusedResources">Take a Photo or Video</string>