Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress-iOS Edition [Do Not Merge] #816

Draft
wants to merge 23 commits into
base: trunk
Choose a base branch
from
Draft

WordPress-iOS Edition [Do Not Merge] #816

wants to merge 23 commits into from

Conversation

kean
Copy link
Contributor

@kean kean commented Jul 12, 2024

Description

This branch contains an archived version of WordPressKit designed to be used exclusively by WordPress-iOS. Consider it a release branch.

This version of WordPressKit is distributed using SwiftPM as a binary target. It has no dependencies to WordPressShared and UIDeviceIdentifier, and it imports wpxmlrpc and NSObject_SafeExtensions as @_implementationOnly, so there are not exposed in the public interface.

Updating WordPressKit

On an off chance that the WordPressKit version used by WordPress-iOS needs a patch, please submit it by targeting this branch.

Deployment Instructions

The deployment currently requires a few manual steps, but we don't expect it to be needed often.

  • Run .buildkite/create-xcframeworks.sh to create binaries
  • Upload .build/xcframeworks/WordPressKit.zip to this repo
  • Update binary target in Package.swift with a new URL and checksum*
  • Push the new changes to your branch
  • (After testing is done) Merge changes in wpios-edition

checksum is echoed at the end of the create-xcframeworks.sh script

@dangermattic
Copy link
Collaborator

dangermattic commented Jul 12, 2024

2 Warnings
⚠️ Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@kean kean changed the title WordPress-iOS Edition WordPress-iOS Edition [Do Not Merge] Jul 13, 2024
@kean
Copy link
Contributor Author

kean commented Jul 13, 2024

Versions:

@kean kean force-pushed the wpios-edition branch 2 times, most recently from ed81029 to 7ab0ebe Compare July 13, 2024 01:22
@kean kean requested a review from jkmassel July 15, 2024 13:42
@kean kean marked this pull request as ready for review July 15, 2024 13:42
@kean kean marked this pull request as draft July 15, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants