Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an unit test for path parameters that contain query #732

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add an unit test for path parameters that contain query #732

merged 1 commit into from
Feb 21, 2024

Conversation

crazytonyli
Copy link
Contributor

Description

See wordpress-mobile/WordPress-iOS@3de5c2f for details.

Testing Details

See the added unit test.

  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@crazytonyli crazytonyli requested a review from mokagio February 20, 2024 23:27
@crazytonyli crazytonyli force-pushed the add-unit-test-path-with-query branch from 3b24fcf to ea9b951 Compare February 20, 2024 23:28
@crazytonyli crazytonyli force-pushed the add-unit-test-path-with-query branch from ea9b951 to e3030fe Compare February 21, 2024 00:10
mokagio
mokagio approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that this is a PR that "only" adds a test.

@crazytonyli crazytonyli merged commit d67877f into trunk Feb 21, 2024
7 checks passed
@crazytonyli crazytonyli deleted the add-unit-test-path-with-query branch February 21, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokagio mokagio mokagio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crazytonyli @mokagio