Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dangermattic configuration #730

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

iangmaia
Copy link
Contributor

Description

This PR adds Dangermattic to this repo.
My main goal was to add RuboCop, but I added some other basic checks as well.
Please let me know if it makes sense to add more checks seen in other repos (reference)

Testing Details

The main validation is to make sure CI is 🟢.

To run Danger yourself:

  1. Checkout this branch
  2. Run bundle install
  3. Run:
DANGER_GITHUB_API_TOKEN=<github_token> bundle exec danger pr <PR_URL>

You should get in the console the same errors / warnings reported in the PR.


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@iangmaia iangmaia self-assigned this Feb 19, 2024
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second action run passed but @dangermattic was not able to report.

image

I added it as a collaborator to the repo, and verified it can report.

:shipit:

@iangmaia iangmaia merged commit cc29a13 into trunk Feb 20, 2024
7 checks passed
@iangmaia iangmaia deleted the iangmaia/dangermattic-setup branch February 20, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants