Fix an XMLRPC uploading file issue (#734)

wordpress-mobile · Feb 21, 2024 · f335202 · f335202
2 parents 4df2b39 + 02a1230
commit f335202
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/WordPressKit/HTTPRequestBuilder.swift b/WordPressKit/HTTPRequestBuilder.swift
@@ -229,7 +229,7 @@ final class HTTPRequestBuilder {
         } else {
             let data = try encoder.dataEncoded()
             request.setValue("\(data.count)", forHTTPHeaderField: "Content-Length")
-            return try .left(encoder.dataEncoded())
+            return .left(data)
         }
     }
 }

diff --git a/WordPressKitTests/Utilities/HTTPRequestBuilderTests.swift b/WordPressKitTests/Utilities/HTTPRequestBuilderTests.swift
@@ -412,4 +412,18 @@ class HTTPRequestBuilderTests: XCTestCase {
         )
     }
 
+    func testXMLRPCUpload() throws {
+        let file = try XCTUnwrap(Bundle(for: type(of: self)).url(forResource: "me-settings-success", withExtension: "json"))
+        let fileContentBase64 = try Data(contentsOf: file).base64EncodedString()
+        let fileStream = try XCTUnwrap(InputStream(url: file))
+        let request = try HTTPRequestBuilder(url: URL(string: "https://w.org/xmlrpc.php")!)
+            .method(.post)
+            .body(xmlrpc: "wp.uploadFile", parameters: ["username", "passowrd", fileStream])
+            .build(encodeBody: true)
+
+        let xmlrpcContent = try XCTUnwrap(request.httpBodyText)
+        let filePart = "<base64>" + fileContentBase64 + "</base64>"
+        XCTAssertTrue(xmlrpcContent.contains(filePart))
+    }
+
 }