-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Subscribers List Card #23067
Merged
Merged
Stats: Subscribers List Card #23067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine DotCom and EmailFollowers into a single list that the store maintains and returns
- Update subscribersList - Subscribe to subscribersList Store updates - Build subscribersListRows()
2 tasks
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
staskus
commented
Apr 24, 2024
14 tasks
guarani
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working great, thanks @staskus!
WordPress/Classes/ViewRelated/Stats/Subscribers/StatsSubscribersViewModel.swift
Show resolved
Hide resolved
staskus
force-pushed
the
task/23046-subscribers-list-card
branch
from
April 25, 2024 05:56
cc88ba4
to
579498e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #23046, details view will be implemented in another PR.
Related WPKit PR: wordpress-mobile/WordPressKit-iOS#797
Adding Subscribers List Card to Subscribers tab, by using the same design as
Insights -> Total Followers
card and consolidating WordPress.com and Email subscribers.Solution
subscribersList
toSubscribersStore
by combining email and dotcom subscribers just as it's done on the web p1713873041361109-slack-C06BR07TJHKsubscribersListRows
using the same row as inInsights
To test:
Stats Traffic and Subscribers tabs
feature flagSubscribers
card appearsRegression Notes
None
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
Unit tests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: