Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Subscribers List Card #23067

Merged
merged 13 commits into from
Apr 25, 2024
Merged

Stats: Subscribers List Card #23067

merged 13 commits into from
Apr 25, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Apr 23, 2024

Partially implements #23046, details view will be implemented in another PR.
Related WPKit PR: wordpress-mobile/WordPressKit-iOS#797

Adding Subscribers List Card to Subscribers tab, by using the same design as Insights -> Total Followers card and consolidating WordPress.com and Email subscribers.

Solution

  1. Added subscribersList to SubscribersStore by combining email and dotcom subscribers just as it's done on the web p1713873041361109-slack-C06BR07TJHK
  2. Built subscribersListRows using the same row as in Insights
  3. Renamed strings that are necessary for subscribers list
  4. Updated tests

To test:

  1. Enable Stats Traffic and Subscribers tabs feature flag
  2. Open Stats
  3. Open Subscribers
  4. Confirm that Subscribers card appears
  5. Confirm that "View more" button exists for sites with more than 6 subscribers
  6. Compare with designs IqhXWz3Iir7RMb5XH5gGfZ-fi-883%3A4006
image

Regression Notes

  1. Potential unintended areas of impact

None

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

  2. What automated tests I added (or what prevented me from doing so)

Unit tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@staskus staskus self-assigned this Apr 23, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23067-579498e
Version24.7
Bundle IDorg.wordpress.alpha
Commit579498e
App Center BuildWPiOS - One-Offs #9652
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 23, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23067-579498e
Version24.7
Bundle IDcom.jetpack.alpha
Commit579498e
App Center Buildjetpack-installable-builds #8696
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working great, thanks @staskus!

@staskus staskus force-pushed the task/23046-subscribers-list-card branch from cc88ba4 to 579498e Compare April 25, 2024 05:56
@staskus staskus enabled auto-merge April 25, 2024 06:05
@staskus staskus merged commit 1377cb4 into trunk Apr 25, 2024
24 checks passed
@staskus staskus deleted the task/23046-subscribers-list-card branch April 25, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants