-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Retry all failed uploads on manual retry #22240
feat: Retry all failed uploads on manual retry #22240
Conversation
Retrying all failed media uploads when tapping the "Retry" button for a single media item improves the UX and aligns with the Android product's existing behavior.
b41b0e7
to
b75c597
Compare
603417d
to
a433e2a
Compare
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test successfully using an internal build and observed that all failed uploads retried when one failed item was tapped. 🚀
As with other related PRs, removing the release note until we remove the debug/internal build flag.
👋 I came across this while testing 24.1's features. Is it still possible to manually retry an image upload? When I turn the network back on, the uploads automatically resume (so there's no opportunity to retry manually). Was this superseded by #22282 which made the upload automatically resume after the network returns? |
Yes, it is still possible to manually retry an upload. Although the uploads will attempt to restart automatically, the upload failed state still exists. It's possible to trigger a failure by throttling the device connection to a weak 3G/4G -- we're working on improving the UX of that scenario in wordpress-mobile/gutenberg-mobile#6583 (with video examples of failed uploads and manual retry attempts). If you have any further feedback on the upload failures/retries, it is very welcome on that thread. And thanks for testing! 🙇 |
@guarani thank you for testing. Leveraging a proxy — like Charles Proxy — to temporarily force a server error might be a straightforward way to test manual retries, as it will not trigger automatic retries. |
Thanks for the info folks! 🙇 |
Description
Retrying all failed media uploads when tapping the "Retry" button for a
single media item improves the UX and aligns with the Android product's
existing behavior.
Fixes wordpress-mobile/gutenberg-mobile#6408.
Testing Instructions
Regression Notes
Media upload for various block types.
Inserted and attached media for various block types.
None, lack of familiarity with testing technology and lack of example unit
tests.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: