Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove per app language feature flag #21516

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

nbradbury
Copy link
Contributor

This work-in-progress PR removes the per app language experimental feature flag, which enables AndroidX per app language handling for all users. This PR is so large because it also drops LocaleAwareActivity which was extended by dozens of activities.

@nbradbury nbradbury added Localization Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Dec 11, 2024
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 11, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21516-6e98d75
Commit6e98d75
Direct Downloadwordpress-prototype-build-pr21516-6e98d75.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 11, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21516-6e98d75
Commit6e98d75
Direct Downloadjetpack-prototype-build-pr21516-6e98d75.apk
Note: Google Login is not supported on these builds.

Copy link

sonarcloud bot commented Dec 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants