Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: remove avg "view more" link #21457

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Nov 13, 2024

Partially resolves #21451

As noted in the issue, tapping this link in stats does nothing because this line of code explicitly states to do nothing.

stats

It turns out this was simply due to fixing a warning about a non-exhaustive when clause.

nothing

We don't have a screen for average daily views and creating one doesn't seem like a priority, so this PR simply removes the "View more" link. I've filed #21458 as a reminder that we should add that screen at some point to match iOS.

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 13, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 13, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21457-ba6d8d6
Commitba6d8d6
Direct Downloadjetpack-prototype-build-pr21457-ba6d8d6.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 13, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21457-ba6d8d6
Commitba6d8d6
Direct Downloadwordpress-prototype-build-pr21457-ba6d8d6.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury changed the title Issue/21451 avg view more link Stats: remove avg "view more" link Nov 13, 2024
@nbradbury nbradbury marked this pull request as ready for review November 13, 2024 18:30
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (a81d9ef) to head (ba6d8d6).
Report is 12 commits behind head on trunk.

Files with missing lines Patch % Lines
...resh/lists/detail/PostAverageViewsPerDayUseCase.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21457   +/-   ##
=======================================
  Coverage   39.50%   39.50%           
=======================================
  Files        2119     2119           
  Lines       99437    99437           
  Branches    15282    15282           
=======================================
  Hits        39281    39281           
  Misses      56674    56674           
  Partials     3482     3482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury requested a review from dcalhoun November 13, 2024 18:59
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sound, testing succeeded.

@nbradbury nbradbury merged commit fb219f1 into trunk Nov 13, 2024
23 checks passed
@nbradbury nbradbury deleted the issue/21451-avg-view-more-link branch November 13, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking "View more" link under "Avg views per day" does nothing
4 participants