-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: remove avg "view more" link #21457
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
…into issue/21451-avg-view-more-link
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21457 +/- ##
=======================================
Coverage 39.50% 39.50%
=======================================
Files 2119 2119
Lines 99437 99437
Branches 15282 15282
=======================================
Hits 39281 39281
Misses 56674 56674
Partials 3482 3482 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sound, testing succeeded.
Partially resolves #21451
As noted in the issue, tapping this link in stats does nothing because this line of code explicitly states to do nothing.
It turns out this was simply due to fixing a warning about a non-exhaustive
when
clause.We don't have a screen for average daily views and creating one doesn't seem like a priority, so this PR simply removes the "View more" link. I've filed #21458 as a reminder that we should add that screen at some point to match iOS.