[Tooling] Ignore values-night/colors_aztec.xml linter errors properly this time
#16293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By annotating the 2 problematic color resources individually, instead of adjusting the exception rule with a too-broad regexp See https://github.com/wordpress-mobile/WordPress-Android/pull/16285\#discussion_r846318394
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
AliSoftware
changed the title
values-night/colors_aztec.xml properlyvalues-night/colors_aztec.xml linter errors properly this time
Generated by 🚫 dangerJS |
|
FYI: This fix made it to 19.6-rc-3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the rightful feedback from @oguzkocer in #16285 (comment) and re-solves the linter errors on
aztec-colors.xmlin a more individual way, more in line we what I discussed with @ParaskP7 in Zoom and Slack.That way, when we get time to investigate those linter errors in more details later, we already have the problematic ones to look at first being isolated and pre-identified; and annotating those individually will also prevent future colors or other resources added later to be missed as being unused.