Skip to content

Commit

Permalink
Fix values-night/colors_aztec.xml properly
Browse files Browse the repository at this point in the history
By annotating the 2 problematic color resources individually, instead of adjusting the exception rule with a too-broad regexp

See https://github.com/wordpress-mobile/WordPress-Android/pull/16285\#discussion_r846318394
  • Loading branch information
AliSoftware committed Apr 11, 2022
1 parent ad8cf9e commit 5e72a1b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions WordPress/src/main/res/values-night/colors_aztec.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?><!--Overloaded Aztec colors. Remove after Aztec is phased out.-->
<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="MissingDefaultResource">
<color name="format_bar_background">#282828</color> <!-- 4dp elevated surface -->
<color name="format_bar_divider">?android:attr/listDivider</color>
<color name="format_bar_background" tools:ignore="UnusedResources">#282828</color> <!-- 4dp elevated surface -->
<color name="format_bar_divider" tools:ignore="UnusedResources">?android:attr/listDivider</color>
<color name="text">@color/material_on_surface_emphasis_high_type</color>
<color name="title_color">@color/text</color>
<color name="hint_text">@color/material_on_surface_emphasis_medium</color>
Expand Down
2 changes: 1 addition & 1 deletion config/lint.xml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
<ignore path="**/WordPressEditor/**" />
<ignore path="**/.gradle/caches/**" />
<ignore path="**/generated/**" />
<ignore regexp=".*\/values\-([a-z]|[A-Z]|\-){2,6}\/.*\.xml$"/>
<ignore regexp=".*\/values\-([a-z]|[A-Z]|\-){2,6}\/strings\.xml$"/>
</issue>

<issue id="Typos" severity="error">
Expand Down

0 comments on commit 5e72a1b

Please sign in to comment.