Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Make pod trunk push be --synchronous, to fix issue when releasing both pods together #1391

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Nodes with values to reuse in the pipeline.
common_params:
plugins: &common_plugins
- automattic/a8c-ci-toolkit#2.13.0
- automattic/a8c-ci-toolkit#3.3.0
# Common environment values to use with the `env` key.
env: &common_env
IMAGE_ID: xcode-13
Expand Down
5 changes: 4 additions & 1 deletion .buildkite/publish-aztec-pod.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ echo "--- :rubygems: Setting up Gems"
install_gems

echo "--- :cocoapods: Publishing Pod to CocoaPods CDN"
publish_pod $PODSPEC_PATH
# Using `--synchronous` here because Editor depends on Aztec, and we need
# to be able to `pod trunk push` the Editor pod immediately after the Aztec
# pod has been published, without being hindered by the CDN propagation time.
publish_pod --synchronous $PODSPEC_PATH

echo "--- :cocoapods: Publishing Pod to WP Specs Repo"
publish_private_pod $PODSPEC_PATH $SPECS_REPO "$SPEC_REPO_PUBLIC_DEPLOY_KEY"
Expand Down
5 changes: 4 additions & 1 deletion .buildkite/publish-editor.pod.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ echo "--- :rubygems: Setting up Gems"
install_gems

echo "--- :cocoapods: Publishing Pod to CocoaPods CDN"
publish_pod $PODSPEC_PATH
# Using `--synchronous` here because Editor depends on Aztec, and we need
# to be able to `pod trunk push` the Editor pod immediately after the Aztec
# pod has been published, without being hindered by the CDN propagation time.
publish_pod --synchronous $PODSPEC_PATH

echo "--- :cocoapods: Publishing Pod to WP Specs Repo"
publish_private_pod $PODSPEC_PATH $SPECS_REPO "$SPEC_REPO_PUBLIC_DEPLOY_KEY"
Expand Down