[자동차 경주] 정상경 미션 제출합니다. #449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERROR CASE가 입력받을 때만 있으므로 모든 적합성판단을 한번에 하려고 한다. nameVaild -> inputVaild
입력을 나누어 받으므로 매 입력마다 유효성 검사를 하는 것이 사용자 입장에서 좋을 것이라고 판단함.
함수 이름 통일성에 맞게 변경
우승자를 판별할 때 문자열 비교보다 숫자 비교하는 것이 더 용이해서 변경함.
carRun의 하는 일이 잘 이해되도록 내부 함수들을 밖으로 분리하여 추상화했다.
하는 일이 무엇인지 이해하기 쉽도록 이름에 random을 추가했다
차 이름에 공백이 들어가 억울하게 5자초과 에러에 걸리는 것을 방지했다!
요구사항에 맞도록 추가했다.
jest에서 test하려면 함수를 export해야한다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.