Obey EC rules #20
Obey EC rules #20
Conversation
|
Oh no!! |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
============================================
- Coverage 89.60% 89.52% -0.08%
- Complexity 437 438 +1
============================================
Files 33 33
Lines 1193 1203 +10
============================================
+ Hits 1069 1077 +8
- Misses 124 126 +2
|
|
It was berry 🍓 hard to forge strings! |
| @@ -271,14 +272,17 @@ public function compile( | |||
| if (array_key_exists("class", $constructorArgument)) { | |||
| $definition = $compilation->getDefinition($constructorArgument["class"]); | |||
|
|
|||
| $code .= "\n{$constructorIndent}{$tab}" . $this->compileEntryReference( | |||
| $code .= $this->indentLines("{$constructorIndent}{$tab}", $this->compileEntryReference( | |||
There was a problem hiding this comment.
if you generate the example container with the make build command, you'll see that this makes the indentation of the dependencies of PlantService wrong. The rest of the changes look good though.
There was a problem hiding this comment.
Fixed 🍏
Is it all right now?
There was a problem hiding this comment.
I don't understand why this change is needed at all when the original indentation looked good for me?
There was a problem hiding this comment.
var_export has a fixed indentation of 2 spaces.
a1be5e7#diff-735c9178f83fdb6831e51d7073bcee55372c3a5c83b4bed1edf08deffb7fe774
To correct that I've added this method.
Can be checked on your local machine/CI workflow with https://github.com/greut/eclint