Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure early return of response is respected when conditional Middleware is involved #35

Conversation

holtkamp
Copy link
Contributor

as reported in #34, feel free to modify this PR if required...

@kocsismate
Copy link
Member

Very clever implementation, I love it, thank you again! I'm merging it for now, and I'll release a new version sometime soon.

@kocsismate kocsismate merged commit 6ed8702 into woohoolabs:master Sep 28, 2024
11 checks passed
@holtkamp
Copy link
Contributor Author

holtkamp commented Sep 30, 2024

Very clever implementation, I love it, thank you again!

Thanks!

I'll release a new version sometime soon.

I suppose a 8.0.1 bug fix release would suffice for this, right?

@kocsismate
Copy link
Member

Yes, and I've just released it :)

@holtkamp holtkamp deleted the patch-early-return-in-conditional-middleware branch October 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants