Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fixing #135

Merged
merged 39 commits into from
Dec 17, 2021
Merged

Bug Fixing #135

merged 39 commits into from
Dec 17, 2021

Conversation

lauramelos
Copy link
Contributor

All Submissions:

  • Does your code follow the Extendables standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

  • Fix issue #120 Force Decimals to 2 on amounts sent to API to prevent errors on api calls. WooCommerce support more that 2 digit on their setting, this enables merchants to connect with some ERP systems that required this due to rounding issues.
  • Fix Issue #125. Save Amazon Reference Id on order _transaction_id order meta field on payment process.
  • Hide the API V1 keys on setting when the V2 onboarding is done.
  • Fix Issue related with Disable option "Hide standard checkout button on cart page" when other payment gateway are activated. Bug in this fix 314c602 that hides the gateway on the new installs.

lauramelos and others added 30 commits July 16, 2021 15:41
@lauramelos
Check if other gateways is enabled before hide checkout button issue #97
314c602
@msaggiorato
Merge pull request #118 from saucal/fix/hide-standard-checkout-button
5d7a5b0 
Check if other gateways is enabled before hide checkout button issue #97
@lauramelos
Enable subscription amount change support Issue #106
2d1fe9a
@msaggiorato
Merge pull request #119 from saucal/fix/support-recursive-coupons
f772df7 
Enable subscription amount change support
@lauramelos
Accept states without letters mark variations on shipping restriction…
d94072e 
… - Issue #122
@lauramelos
Render cart button on update shipping method
4a04dbe
@msaggiorato
Merge pull request #127 from saucal/feature/state-restrictions
8649ea9 
Accept states without letters mark variations on shipping restriction…
@msaggiorato
Merge pull request #126 from saucal/feature/cart-button-render
395acf2 
Render cart button on update shipping method
@lauramelos
Unify version checker
3fe0ed8
@lauramelos
Get order charge permission and charge id method
4ae7df0
@lauramelos
Force v2 version on orders
6c8ad9e
@lauramelos
Remove duplicated assignation
98925d1
@lauramelos
Add charge id for the orders with open capture
3fc9695
@lauramelos
Parse V1 ipn response to process it with V2 handler
014e20e
@lauramelos
Skip v1 IPN handler on migration done
b76836b
@lauramelos
Lowercase version on parsed IPN notification
a8ce149
@lauramelos
Change string replace function and save order
cf90dde
@lauramelos
Log notification Data for the V1 IPN
75dca78
@msaggiorato
Fix typos
71282ee
@msaggiorato
PHPCS issues
7d870f8
@msaggiorato
PHPCS manual fixes
7c32df4
@msaggiorato
PHPCS fixes
f20eac1
@msaggiorato
Fix function call.
88b35f8
@msaggiorato
Undo version change
6111dc9
@lauramelos
Merge pull request #129 from saucal/fix/coding-standards
ac2e497 
Fix coding standards issues
@lauramelos
Merge pull request #128 from saucal/feature/legacy-remove
a2e5b39 
Feature/legacy remove
@lauramelos
Replace gateways object to avoid error on settings
61a3f01
@lauramelos
Set Order Transaction Id
009bc02 
(Saucal Issue #125)
@lauramelos
Force Decimals to 2 on amounts sent to API
f89b6eb
@msaggiorato
Merge pull request #134 from saucal/feature/set-transaction-id
edae818 
Set standard Transaction Id
msaggiorato and others added 9 commits November 30, 2021 19:17
@lauramelos lauramelos requested a review from kalessil December 15, 2021 15:37
@lauramelos lauramelos changed the title Develop Bug Fixing Dec 15, 2021
kalessil
kalessil approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@kalessil kalessil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kalessil kalessil merged commit 61ccbab into woocommerce:main Dec 17, 2021
@kalessil
Copy link
Contributor

Thank you @lauramelos !

@kalessil kalessil mentioned this pull request Jan 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalessil kalessil kalessil approved these changes

Assignees
No one assigned
Labels
Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauramelos @kalessil @msaggiorato