Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility aelia currency switcher #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daigo75
Copy link

@daigo75 daigo75 commented May 26, 2021

I've been asked by my client to open a new pull request, since the #86 was closed, probably by mistake, without a merge.

All Submissions:

  • Does your code follow the Extendables standards? I think so, but can't say, the link to the standards can't be reached.
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changes proposed in this Pull Request:

Integration with the Aelia Currency Switcher, for multi-currency support. We proposed the same integration a few months ago to Sau/Cal, but it hasn't been added to the Amazon Pay plugin, yet.

How to test the changes in this Pull Request:

  1. Install and configure the Aelia Currency Switcher (free copy available on request), enabling multiple currencies.
  2. Go to WooCommerce > Settings > Payments > Amazon Pay.
  3. Verify that the integration is active (see https://prnt.sc/10d2jg0).
  4. Enable Amazon Pay for some currencies in the gateway settings.
  5. Enable Amazon Pay for the same currencies at WooCommerce > Currency Switcher > Payment Gateways (see https://prnt.sc/10d2izo).
  6. Place an order in the enabled currencies, paying with Amazon. and verify that it's processed correctly.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changelog entry

Added integration with the Aelia Currency Switcher, for multi-currency support.

Diego added 2 commits March 1, 2021 14:28
* Put the Aelia Currency Switcher at the top of the list, to ensure that it's detected even when WCML is installed.
@amistry007
Copy link

Anybody working on fixing this as need the Aelia currency switcher support urgently.

@RalucaSbN
Copy link

Please work on fixing the Aelia currency switcher asap as we need this. Thanks!

@daigo75
Copy link
Author

daigo75 commented Dec 21, 2022

@RalucaSbN just a minor clarification, if I may. The Aelia Currency Switcher already works, it doesn't need fixing. The integration should just be a matter of merging the changes I proposed.

@RalucaSbN
Copy link

RalucaSbN commented Jan 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants