This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Stock Indicator block: Add support for global style #5525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmerce-gutenberg-products-block into add/4965-stock-indicator
Stock indicator block: add support for global style
gigitux
added
type: enhancement
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
gigitux
added
status: blocked
18 tasks
|
Size Change: +385 B (0%) Total Size: 817 kB
ℹ️ View Unchanged
|
…products-block into add/4965-stock-indicator
gigitux
removed
the
status: blocked
dinhtungdu
reviewed
Jan 13, 2022
Comment on lines
1
to
21
| /** | ||
| * External dependencies | ||
| */ | ||
| import { useBlockProps } from '@wordpress/block-editor'; | ||
| import classnames from 'classnames'; | ||
|
|
||
| type Props = { | ||
| attributes: Record< string, unknown > & { | ||
| className?: string; | ||
| }; | ||
| }; | ||
|
|
||
| export const Save = ( { attributes }: Props ): JSX.Element => { | ||
| return ( | ||
| <div | ||
| { ...useBlockProps.save( { | ||
| className: classnames( 'is-loading', attributes.className ), | ||
| } ) } | ||
| /> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
This code is for the Sale badge block. Was it added by accident?
Comment on lines
-7
to
-16
| &--in-stock { | ||
| color: $in-stock-color; | ||
| } | ||
| &--out-of-stock { | ||
| color: $no-stock-color; | ||
| } | ||
| &--low-stock, | ||
| &--available-on-backorder { | ||
| color: $low-stock-color; | ||
| } |
There was a problem hiding this comment.
We are removing the feature that store owners actually need here. The current Supports API doesn't allow multiple colors, so I don't think it's a good idea to remove styles for stock statuses. Instead, we should accept the limitation of the Supports API. In the other words, ignoring the color, only add global style support for typography.
We can also create custom inspector settings to control colors for each state, and it will be local block style only, not global style.
There was a problem hiding this comment.
We are removing the feature that store owners actually need here. The current Supports API doesn't allow multiple colors, so I don't think it's a good idea to remove styles for stock statuses.
Before proceeding, I asked the rest of the team. Please check this discussion (p1641461102003800-slack-C02FL3X7KR6), maybe we can continue the discussion there.
| }, | ||
| } ), | ||
| typography: { | ||
| fontSize: true, |
There was a problem hiding this comment.
It makes sense to me to support all typography properties for this block instead of only font size. At least, font-weight and text-transform should be supported.
There was a problem hiding this comment.
Yes, makes sense to me. I tested the Post Categories block from Gutenberg and it offers many more typography options than what we offer in Stock indicator.
I guess the same could be said about the Product Category List, Product Summary and Product Tag List.
@vivialice what are your thoughts on this? Should we enable all typography properties in those blocks?
…products-block into add/4965-stock-indicator
dinhtungdu
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
According to main issue #4965, we should enable only font-size, but yeah we can enable them easily.
I agree to follow the requirements. We can merge this PR as it is for now and add more properties later. By doing so, we don't block the release of the Global Style project.
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #5515This PR adds support for global style for the
Summary Product block.Now, the user can edit the style for:
#4965
Screenshots
without global style
with global style
Testing
Manual Testing
Check out this branch:
WordPress 5.9, install and enable theGutenbergplugin.Twenty Twenty-Twotheme.Single Product block(this block containsStock Indicator block) to a post.Stock Indicator block.Resetbutton from the different sections.Stylesicon on the right-top corner.Stock Indicator blockis shown under theBlockssection. Personalize again the block.Changelog