Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add storybook demo for Chip #3029

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Add storybook demo for Chip #3029

merged 2 commits into from
Jun 14, 2021

Conversation

haszari
Copy link
Member

@haszari haszari commented Aug 20, 2020 •
edited by opr
Loading

Part of #3031

Accessibility

How to test the changes in this Pull Request:

  1. Execute npm run storybook and visit the URL (mine is http://localhost:6006/)
  2. Navigate to @base-components > Chip and apply the following testing steps to both Chip and RemovableChip
  3. Change the knobs at the bottom of the storybook panel and ensure the expected changes occur to the component.
  4. Test with screen reader on and by using only the keyboard.
  5. Check the accessibility tab of Storybook and verify that the contrast of the component is ok.

@haszari
Copy link
Member Author

haszari commented Aug 20, 2020

While working on this I noticed that our Storybook is out of date, and the new Storybook seems to have quite a different API.

Would be good to get updated soon and use the new API/approach for new stories.

Logged here: #3028

@haszari
Copy link
Member Author

haszari commented Aug 20, 2020

FYI @woocommerce/rubik - if you're writing new stories, this branch has some (Chip CheckboxControl so far).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.98 kB 0 B
build/active-filters.js 7.49 kB 0 B
build/all-products-frontend.js 35.6 kB 0 B
build/all-products.js 36.4 kB 0 B
build/all-reviews.js 9.15 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.39 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.94 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 335 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 8.64 kB 0 B
build/atomic-block-components/add-to-cart.js 7.7 kB 0 B
build/atomic-block-components/button-frontend.js 1.72 kB 0 B
build/atomic-block-components/button.js 843 B 0 B
build/atomic-block-components/category-list-frontend.js 470 B 0 B
build/atomic-block-components/category-list.js 479 B 0 B
build/atomic-block-components/image-frontend.js 1.65 kB 0 B
build/atomic-block-components/image.js 1.31 kB 0 B
build/atomic-block-components/price-frontend.js 1.98 kB 0 B
build/atomic-block-components/price.js 2 kB 0 B
build/atomic-block-components/rating-frontend.js 519 B 0 B
build/atomic-block-components/rating.js 526 B 0 B
build/atomic-block-components/sale-badge-frontend.js 470 B 0 B
build/atomic-block-components/sale-badge.js 476 B 0 B
build/atomic-block-components/sku-frontend.js 388 B 0 B
build/atomic-block-components/sku.js 395 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 569 B 0 B
build/atomic-block-components/stock-indicator.js 573 B 0 B
build/atomic-block-components/summary-frontend.js 904 B 0 B
build/atomic-block-components/summary.js 914 B 0 B
build/atomic-block-components/tag-list-frontend.js 466 B 0 B
build/atomic-block-components/tag-list.js 472 B 0 B
build/atomic-block-components/title-frontend.js 1.4 kB 0 B
build/atomic-block-components/title.js 1.26 kB 0 B
build/attribute-filter-frontend.js 17.7 kB 0 B
build/attribute-filter.js 11.3 kB 0 B
build/blocks-checkout.js 20.9 kB 0 B
build/blocks.js 3.49 kB 0 B
build/cart-frontend.js 78 kB 0 B
build/cart.js 44 kB 0 B
build/checkout-frontend.js 82 kB 0 B
build/checkout.js 46.1 kB 0 B
build/editor-rtl.css 14.9 kB 0 B
build/editor.css 14.9 kB 0 B
build/featured-category.js 7.22 kB 0 B
build/featured-product.js 9.46 kB 0 B
build/handpicked-products.js 5.89 kB 0 B
build/price-filter-frontend.js 14.2 kB 0 B
build/price-filter.js 9.27 kB 0 B
build/price-format.js 1.47 kB 0 B
build/product-best-sellers.js 6.09 kB 0 B
build/product-categories.js 3.23 kB 0 B
build/product-category.js 6.97 kB 0 B
build/product-new.js 6.25 kB 0 B
build/product-on-sale.js 6.6 kB 0 B
build/product-search.js 2.55 kB 0 B
build/product-tag.js 6.09 kB 0 B
build/product-top-rated.js 6.22 kB 0 B
build/products-by-attribute.js 6.97 kB 0 B
build/reviews-by-category.js 11.2 kB 0 B
build/reviews-by-product.js 12.8 kB 0 B
build/reviews-frontend.js 8.93 kB 0 B
build/single-product-frontend.js 39 kB 0 B
build/single-product.js 9.73 kB 0 B
build/style-rtl.css 18.8 kB 0 B
build/style.css 18.8 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 6.54 kB 0 B
build/vendors-style-rtl.css 1.05 kB 0 B
build/vendors-style.css 1.05 kB 0 B
build/vendors.js 420 kB 0 B
build/wc-blocks-data.js 10.6 kB 0 B
build/wc-blocks-google-analytics.js 1.99 kB 0 B
build/wc-blocks-middleware.js 1.49 kB 0 B
build/wc-blocks-registry.js 2.75 kB 0 B
build/wc-payment-method-bacs.js 812 B 0 B
build/wc-payment-method-cheque.js 807 B 0 B
build/wc-payment-method-cod.js 903 B 0 B
build/wc-payment-method-paypal.js 844 B 0 B
build/wc-payment-method-stripe.js 12.4 kB 0 B
build/wc-settings.js 2.93 kB 0 B
build/wc-shared-context.js 1.54 kB 0 B
build/wc-shared-hocs.js 1.73 kB 0 B

compressed-size-action

@haszari haszari force-pushed the add/stories-for-reusable-components branch from 27f749e to 55d563d Compare August 20, 2020 10:38
@haszari haszari changed the title Add new stories for potentially reusable components Add storybook demo for Chip Aug 20, 2020
@haszari haszari mentioned this pull request Aug 20, 2020
Closed
2 tasks
@nerrad nerrad changed the base branch from main to trunk September 26, 2020 17:30
@nerrad nerrad added tools Used for work on build or release tools. type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. labels Oct 1, 2020
@opr opr self-assigned this Dec 4, 2020
@opr opr marked this pull request as ready for review December 9, 2020 16:57
@opr opr requested a review from a team as a code owner December 9, 2020 16:57
@opr opr requested review from senadir and removed request for a team December 9, 2020 16:57
@opr opr force-pushed the add/stories-for-reusable-components branch from 55d563d to c118a33 Compare December 14, 2020 13:29
@github-actions
Copy link
Contributor

This PR has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface pull requests that have slipped through review.

If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 13, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Feb 16, 2021
@github-actions
Copy link
Contributor

This PR has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface pull requests that have slipped through review.

If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days.

@github-actions github-actions bot added the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 19, 2021
@github-actions github-actions bot closed this Apr 30, 2021
@nerrad nerrad reopened this Apr 30, 2021
@nerrad nerrad removed the status: stale Stale issues and PRs have had no updates for 60 days. label Apr 30, 2021
@opr opr force-pushed the add/stories-for-reusable-components branch from c118a33 to 370fff6 Compare May 18, 2021 08:17
@opr opr added the skip-changelog PRs that you don't want to appear in the changelog. label Jun 14, 2021
@opr opr added this to the 5.4.0 milestone Jun 14, 2021
@opr opr merged commit ca6f4ea into trunk Jun 14, 2021
@opr opr deleted the add/stories-for-reusable-components branch June 14, 2021 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@senadir senadir senadir approved these changes

Assignees

@opr opr

Labels
skip-changelog PRs that you don't want to appear in the changelog. tools Used for work on build or release tools. type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@haszari @senadir @nerrad @opr