Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run PHPCS in CI #102

Open
wants to merge 5 commits into
base: 22-07/lower-version-requirement
Choose a base branch
from
Open

Run PHPCS in CI #102

wants to merge 5 commits into from
+41 −4

Conversation

Luc45
Copy link
Member

@Luc45 Luc45 commented Jun 30, 2022 •
edited
Loading

Changes proposed in this Pull Request:

This PR introduces a GitHub workflow to run PHPCS checks in CI on Push event. This is interesting to have, as PHPCS tests the PHP compatibility with the minimum PHP version required by the project.

How to test the changes in this Pull Request:

  1. Merge this PR to trunk
  2. Push code to a remote branch
  3. Assert it runs PHPCS in CI
  4. Assert that the badge in README.md is as expected.

Changelog entry

Run PHPCS checks in CI

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@Luc45 Luc45 self-assigned this Jun 30, 2022
@Luc45 Luc45 mentioned this pull request Jun 30, 2022
Closed
1 task
@Luc45 Luc45 requested a review from zhongruige June 30, 2022 17:00
@Luc45 Luc45 removed the request for review from zhongruige July 1, 2022 12:48
@jonathansadowski jonathansadowski requested review from a team, psealock and samueljseay and removed request for a team and psealock September 23, 2022 16:46
samueljseay
samueljseay approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@samueljseay samueljseay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me and a low-cost addition to have this check. Thanks for doing this work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueljseay samueljseay samueljseay approved these changes

Assignees

@Luc45 Luc45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Luc45 @samueljseay