Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“¦ NEW: Add build tools (#12) #16

Closed
wants to merge 1 commit into from

Conversation

nielslange
Copy link
Member

Fixes #12

Add build tools to generate CSS and translations files.

Screenshots

n/a

How to test the changes in this Pull Request:

  1. Check out this PR
  2. Run npm i to install all dependencies β†’ Dependencies should be installed
  3. Run npm run build to build the extension β†’ The file storefront-hamburger-menu.zip should be created in root
  4. Run npm run build:dev to render JS and SCSS files β†’ The files assets/css/style.css, assets/css/style.css.map, assets/css/style.min.css, assets/js/customizer.js, assets/js/customizer.min.js & assets/js/customizer.min.js.map will be rendered
  5. Run npm run start to watch SCSS changes β†’ If src/css/style.scss will be changes, the files assets/css/style.css, assets/css/style.css.map & assets/css/style.min.css will be rendered
  6. Run npm run watch to watch SCSS changes β†’ If src/css/style.scss will be changes, the files assets/css/style.css, assets/css/style.css.map & assets/css/style.min.css will be rendered
  7. Run npm run js to render JS files β†’ The files assets/js/customizer.js, assets/js/customizer.min.js & assets/js/customizer.min.js.map will be rendered
  8. Run npm run css to render SCSS files β†’ The files assets/css/style.css, assets/css/style.css.map & assets/css/style.min.css will be rendered
  9. Run npm run makepot to render the POT file β†’ The file languages/storefront-hamburger-menu.pot will be rendered

Changelog

Dev - Add build tools to generate CSS and translations files. #12

Tests

n/a

Note

Due to insufficient permissions, I wasn't able to send this PR against this repo. Therefore, I had to send the PR via my forked repo.

cc: @jconroy (Pinging you here as I'm also unable to request a review from you.)

@jconroy
Copy link
Member

jconroy commented Sep 27, 2020

LGTM The only extra thing I've done with others is add a readme.md

Update - Ignore me - just noticed you have an issue for adding a readme #15

@nielslange nielslange closed this Oct 4, 2020
@jconroy
Copy link
Member

jconroy commented Feb 22, 2021

Note to self I think that was accidentally closed when the default branch was changed from master to trunk

Also updated the tested up to tag

@nielslange nielslange mentioned this pull request Jul 22, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add build tools
2 participants